Arbitration broadcast DPT and dispute message in parallel. #6818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the dispute message would only be sent once the DPT had finished propagation. To a user it would appear as if nothing happened and they would attempt to initiate the process again. That would cause the DPT logic to fail (we already have an open timer etc..) and the logic failing would result in no happy path therefore no Dispute message being sent. Testing confirmed there is no requirement for the dispute to be chained on the successful propagation of the DPT to nodes. Both the DPT and the dispute can be attempted again by the user if necessary. Rebroadcasting an already published DPT causes no harm. Re-sending the dispute message also causes no harm as there is logic to detect if it already exists and handle it gracefully.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6797
Previously the dispute message would only be sent once the DPT had finished propagation (which can take a few seconds or more on mainnet). To a user it would appear as if their clicking the button had no effect and they would attempt to click again. That would cause the DPT broadcast task to fail (error:
broadcastTx called with a tx which has an open timeoutTimer) and it would result in no happy path therefore no Dispute message / ticket being opened.Testing confirmed there is no requirement for the dispute to be chained on the successful propagation of the DPT to nodes. The send to arbitration can be attempted again if necessary, by pressing CTRL-O / Open support ticket.