-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bisq 2 wiki pages #801
Comments
I agree the wiki for both Bisq 1 and Bisq 2 should be hosted on the same wiki. I would suggest having everything related to Bisq 2 should be contained within: https://bisq.wiki/bisq2 When Bisq 2 is live the main wiki index page: https://bisq.wiki/Main_Page can be changed to give people a choice between information related to Bisq 1 and information related to Bisq 2. The wiki is already a bit mess from a navigation hierarchy point of view so trying to keep everything related to Bisq 2 within it's own sub directory seems to make sense. Eg: https://bisq.wiki/bisq2/roles https://bisq.wiki/bisq2/reputation https://bisq.wiki/bisq2/roles/trade-protcols |
Yes agree. Would you be interested to help on that work? |
Yes, happy to make a start with it laying out the page structure and adding some content that can at least be used as a place holder for the time being until more details are known. Will post the pages below as comments when they have been created. |
Are you still up for that task? We are getting closer to release and need to get those tasks done. |
Yes, will make a start this weekend to put some holding pages together for the wiki. |
@darawhelan Are you still available for that issue? |
Happy to help. Is there any documentation anywhere on how to edit the wiki? The readme on the wiki repo was not helpful. |
Great to hear that the launch of Bisq 2 is coming closer. Can make a start on it this weekend. Would be happy to have @counterweightoperator help me with achieving the deadline. @counterweightoperator I will send you a message on Matrix with info about the wiki (my user is @darawhelan:matrix.org). You will need to get a wiki account set up so you can get started. The wiki is based on MediaWiki, here are some help files about wiki editing here: https://www.mediawiki.org/wiki/Help:Contents |
I have created the following Wiki pages for Bisq 2:
I would be great if @counterweightoperator can do the pages for the Bisq 2 Wallet (I think they have written the guide for the application already) and Bisq 2 Identities. Some of the information I was not able to find out from the documentation / Bisq 2 repository alone without being able to understand the code itself for example (reputation / roles / identity). @HenrikJannsen where is a good place to ask questions about the wiki content? Would you prefer it on this issue? Also I think I would be able to improve the content further with screenshots / more context etc if I had access running Bisq 2. Are there any instructions for how to run the current version of Bisq 2? I am happy to continue to add to the wiki but think I need more information in order to do so. @HenrikJannsen let me know if I am on the right track with this content or if you envisioned something different. |
@darawhelan Great thanks! Re wallet: We will not ship a wallet in the initial release. It is not 100% decided yet which wallet we will use (currently Electrum and Bitcoin core).
Yes I think we can use that GH issue.
Which OS do you use? I can provide you a OSX and deb binary. For a more complete infrastructure (setting up mediators,...) it is a bit more complicated and probably best to wait until we have deployed Tor instances. I hope we are there in the next 2 weeks.
Yes thats the direction I envisioned. To give feedback to the provided text I think it would be easiest to use a gdoc or similar shared edit/feedback tool. |
Is it easy to change the URLs later once Bisq 1 has been retired and Bisq 2 becomes Bisq? I think now its best to prefix all Bisq 2 content with Bisq2 or put it into a sub directory to make clear its about Bisq 2. but later it would be good to get rid of that prefix. |
Agreed, but I could not see how to create a sub directory on the wiki. I tried looking online but did not find anything. Something about Subpages but I needed more access to the wiki than I had. All existing wiki pages are found in the root directory, see: https://bisq.wiki/Special:AllPages If sub directories could be created that would be great, otherwise it has the potential to get a little messy! |
Yes |
I am using Windows 10, not sure if that causes issues. Happy to have a go at running it but would need some support as I have not built something from source before.
Ok will get something set up. |
Questions: Identity Will the identities apply across trade protocols? For example is a Bisq Easy 5 star rated seller is selling Bitcoin on the 2-of-2 multisig protocol will potential buyers see that they are rated 5 star? I was a little confused with the identity section, not sure where to start. Might be better for someone else to write this section. Roles I am happy to have a go at writing this page but I do not know what roles will be included in Bisq 2. I made a list of all the roles I saw mentioned in the repository / discussion. I assume not all will be used: Arbitrator Please let me know which of the above will be roles in Bisq 2 and I will write some content for them. Tor / I2P I am not sure if Bisq 2 will run over Tor initially but then later have the option to run some aspects over I2P? Reputation This is a little confusing for me, but I think I will be able to improve on the content once I have access to the reputation simulation tool. Do you think it is worth including the formulas for how reputation is calculated for each component in the wiki? How is the 5 star system rating calculated? Assuming top users reputation score will be 100% / 5 star and other users become a percentage of that expressed as a star rating (eg user with 20% of top users reputation is 1 star, user is with 60% of top score is 3 star)? |
I heard from a dev who is on windows that there are some issues to get a binary. I will let you know once there is a binary available. |
Yes. An identity is a collection of network addresses (tor, i2p) and a key pair.
Identity and reputation are separate concepts. Reputation is based and tied to one identity. Currently it is not planned to re-use the Bisq Easy reputation for the Multisig protocol. But its something we could consider.
Ok. I can provide a draft.
There are roles and node operators: Roles:
Node operators:
All Bisq 2 roles and nodes must have a BSQ bond setup and be registered via the oracle node which will verify the BSQ bond. Only the root seed node and root oracle node cannot be verified that way as it would be a chicken and egg problem. Though those root nodes are expected to have also their Bond set up and users can manually verify those nodes bond (as well as all the other roles/nodes). All roles/nodes need to get voted ok before setting up their bond. Bisq 1 mediators can re-use their bond they have locked up already.
It was planned to run on both networks, but it seems that I2P is too unstable atm. We likely will deploy with tor enabled only and users can enable I2P in the settings with a warning that its experimental. If a dev sufficient familiar with I2P fixes the open issues we might get to the initial plan.
Hm, not sure. Maybe a screenshot should be enough?
Yes. There are currently 4 sourced for reputation:
Burn BSQ: BSQ bond: Account age witness: Bisq 1 account age: In all cases the user profile ID (pub key hash) is tied to the reputation source. By banning a user their reputation is not usable anymore. Thus the moderator has quite some power. The total score is calculated as sum of the individual reputation sources/events (Burning/Bonding can be repeated). One could phrase it as: The reputation is the relative ranking compared to the reputation of the active users in the network. |
@darawhelan How is the state of that issue? |
Thanks for all the info it is useful. I have taken the info supplied and used it to edit the following pages for Bisq 2:
All the documents above have been created in a shared CryptPad that can be edited: https://cryptpad.fr/drive/#/2/drive/edit/Qe2uck5D-VyNRfDg5jOn3exW/ I have left them in their wiki formatting for easy copy / paste. Please feel free to make any comments or edits.
I have installed java 17 and git on my machine. Is this the correct link to download IntelliJ community version: |
Yes |
I have made additional edits since the feedback provided.
Pages still to be completed by @counterweightoperator:
All the documents are also updated in the shared CryptPad that can be edited: https://cryptpad.fr/drive/#/2/drive/edit/Qe2uck5D-VyNRfDg5jOn3exW/ |
I linked all wiki pages from the app and added a link to identity from the user profile screen. |
What is the state of that issue? Can we estimate a date for completion? |
@HenrikJannsen, from my side, last I heard the |
@darawhelan is there anything pending besides the |
Thanks for your work on the wiki. From my side I need to edit the https://bisq.wiki/Reputation page as the way the reputation is managed has changed and is now a lot clearer to me. I will complete this page this weekend. I also thought I would add a 'How to trade safely on Bisq Easy' page with some tips for buyers and sellers. This page can be developed over time and Bisq 2 can be launched without this page if needed. Regarding the |
I agree. I'll make something for identities, even if we keep short and simple. Thanks @darawhelan. |
I have updated the Reputation wiki page https://bisq.wiki/Reputation |
I have added a 'How to stay safe on Bisq Easy' section to the Bisq Easy wiki https://bisq.wiki/Bisq_Easy#How_to_stay_safe_on_Bisq_Easy |
@darawhelan Can we replace https://bisq.wiki/File:Reputation_measurement.png with a up-to-date image? I guess the content is kind of complete now? Right? If so I would close the issue. |
@darawhelan Is there anything open with that task or can we close it as completed? We should also have a plan how to link the Bisq2 / Bisq Easy pages into the main page (to be deployed at release date) |
Yes, do you have an image I can use to replace it with? Not sure how to access the new images? |
@HenrikJannsen I have completed everything on the wiki from my side bar replacing the image. @counterweightoperator still needs to complete the https://bisq.wiki/Identities page, but the issue can be closed as this page it not required prior to launch.
I think the simplest way to do this is to rename https://bisq.wiki/Main_Page to be https://bisq.wiki/Bisq_1 Then create an new page for https://bisq.wiki/Main_Page that gives users the option between finding out more about: It should be a simple change (Less than 30 mins work). I am happy to do this when needed. |
@darawhelan It might be a good idea to add a couple of optional general tips on how to stay safe. Many of these items are common sense to us veterans, but with the up coming bull cycle there will be a lot of new comers with out this experince. Feel free to make any changes to above suggestions. |
See also bisq-network/wiki#51
Links from Bisq 2 app:
https://bisq.wiki/Bisqeasy
https://bisq.wiki/reputation
https://bisq.wiki/reputation/burnBsq
https://bisq.wiki/reputation/bondedBsq
https://bisq.wiki/reputation/accountAge
https://bisq.wiki/reputation/signedAccount
https://bisq.wiki/bisq2/roles/moderator
https://bisq.wiki/bisq2/roles/mediator
https://bisq.wiki/bisq2/roles/oracle
The text was updated successfully, but these errors were encountered: