Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 33 #1008

Closed
ghubstan opened this issue Feb 20, 2022 · 5 comments
Closed

For Cycle 33 #1008

ghubstan opened this issue Feb 20, 2022 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:not submitted Indicates that a compensation request was not submitted for DAO voting
Milestone

Comments

@ghubstan
Copy link
Member

ghubstan commented Feb 20, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 2520
  • USD requested: 3150
  • BSQ rate: 1.25 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 32 #986

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Add API 'gettrades' method dev 3000 bisq-network/bisq#5976 merged
Modify .proto file comments to be parsed by bisq-grpc-api-doc dev 100 bisq-network/bisq#6042 merged
Fix API FeeService NPE dev 50 bisq-network/bisq#6052 merged

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Title Team USD Link Notes
Bisq API Reference Doc Generator dev https://github.com/ghubstan/bisq-grpc-api-doc producing api reference [wip]
Bisq gRPC API Reference dev https://ghubstan.github.io/slate/#introduction public site
Prepare API Offers .proto defs for significant changes [1] dev bisq-network/bisq#6055 awaiting review
Change API's OfferInfo proto's price field to string [2] dev bisq-network/bisq#6056 awaiting review
Change API grpc.proto triggerPrice field to string [3] dev bisq-network/bisq#6057 awaiting review
Change API OfferInfo volume/minVolume proto fields to string [4] dev bisq-network/bisq#6060 awaiting review
Change TradeInfo proto's tradePrice & tradeVolume fields to string [5] dev bisq-network/bisq#6062 awaiting review
Clarify meaning of API/Offer related % fields [6] dev bisq-network/bisq#6065 awaiting review
[WIP] Continue documenting grpc.proto for API reference site [7] dev bisq-network/bisq#6068 awaiting review
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Feb 20, 2022
@ripcurlx
Copy link
Contributor

As dev team lead I approve this request for dev. Please submit your compensation request to the DAO for voting and post the transaction id here afterwards.

@MwithM MwithM added this to In Review in Compensation Request Board Feb 21, 2022
@MwithM MwithM added this to the Cycle 33 milestone Feb 21, 2022
@MwithM
Copy link
Contributor

MwithM commented Feb 28, 2022

@ghubstan It appears that you forgot to send the compensation request for DAO voting.

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Feb 28, 2022
@ghubstan
Copy link
Member Author

ghubstan commented Mar 1, 2022

@MwithM #!*%!, yes I did forget. Is it too late now? Voting ends in two days...

@ghubstan
Copy link
Member Author

ghubstan commented Mar 1, 2022

@MwithM #!*%!, yes I did forget. Is it too late now? Voting ends in two days...

I see it is too late to make the proposal in the DAO. I"ll have to include it in Cycle 34.

@MwithM MwithM added the was:not submitted Indicates that a compensation request was not submitted for DAO voting label Mar 7, 2022
@MwithM
Copy link
Contributor

MwithM commented Mar 7, 2022

Closed as not submitted.

@MwithM MwithM closed this as completed Mar 7, 2022
Compensation Request Board automation moved this from Review Complete to Closed Mar 7, 2022
@ghubstan ghubstan mentioned this issue Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:not submitted Indicates that a compensation request was not submitted for DAO voting
Projects
Development

No branches or pull requests

3 participants