Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 34 #1027

Closed
w0000000t opened this issue Mar 21, 2022 · 8 comments
Closed

For Cycle 34 #1027

w0000000t opened this issue Mar 21, 2022 · 8 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@w0000000t
Copy link

w0000000t commented Mar 21, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: [577.24]
  • USD requested: [710]
  • BSQ rate: [1.23] USD per BSQ
  • Previous compensation request (if applicable): # For Cycle 33 #1002

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
L1 support agent support 600 bisq-network/roles#64 (comment) mainly active on matrix telegram and forum, some activity on reddit; 600usd as per bisq-network/proposals#368
Contributor opsec heads up support 20 https://bisq.wiki/Contributor_privacy_and_opsec as prompted by one devcall meeting
"send fiat to bisq?" wiki article support 5 https://bisq.wiki/How_do_I_send_fiat_to_Bisq after getting this question so many times
testing 1.8.3 dev 85 https://pastebin.com/KsyDyq0a able verify more PRs this time

Contributions in progress

In case it is of interest, I can further improve this script and implement a web page on Tor where support agents can login to add their own reports, and have stats be compiled automatically at the end of the cycle

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:support https://bisq.wiki/Support_Team team:dev https://bisq.wiki/Dev_Team labels Mar 21, 2022
@MwithM MwithM added this to the Cycle 34 milestone Mar 21, 2022
@MwithM MwithM added this to In Review in Compensation Request Board Mar 21, 2022
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request for dev. It would be great if you could approve/reject your own test scenarios on bisq.ontestpad as well, so it is easier for me to see how detail which parts have been tested in one glance.

@w0000000t
Copy link
Author

w0000000t commented Mar 22, 2022

It would be great if you could approve/reject your own test scenarios on bisq.ontestpad as well, so it is easier for me to see how detail which parts have been tested in one glance.

can absolutely do @ripcurlx , yet can you please explain what you mean, as I didn't quite understand? On testpad, I make sure to tag the tested sections, and in every one of them also attach screenshots of the tested feature + link to PR, example:
image

The link to the pastebin wall of text is to have a better ordered resume of what I actually did, that's what I personally feel would be clearer for me at a glance, and my personal "flight sheet" when I do testing, so I thought I would include it :)

@ripcurlx
Copy link
Contributor

@w0000000t I didn't know that you already did this 👍 I think for test cases that are a pass you don't need to add extra information (of course appreciated), but for fail ones it is good to link the Github issue in the bug tracking field (screenshots will be there anyway I guess). Before I release and/or I start my release testing I review an overview which is similar to this report screen: https://bisq.ontestpad.com/project/1/folder/f153/report/?auth=b91656669a12abf05a9583ff8dbcb213 to see which sections need extra test coverage from my side and who tested what. So when one or two trusted contributors test certain sections I assume that this was tested properly (I normally have tested most of the code changes anyways during a PR review myself).

@w0000000t
Copy link
Author

@ripcurlx I guess I like to make myself accountable, since I'm requesting a compensation, and I attach screenshots to show that I actually did the testing, instead of simply clicking on boxes saying that I did ;) As of now I feel like doing this little extra work, I understand now though how you check "at a glance", and I'll keep doing the pastebin thing for my own convenience and link it in CR if that's okay with you, since my testing is reported on testpad for your checking I believe 👍

@leo816
Copy link

leo816 commented Mar 28, 2022

My Team Lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@w0000000t
Copy link
Author

96cb71a5f2034da95219a0ba3cd389a1167bbfb1417db13f59b9efb496fac53b

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Mar 28, 2022
@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Mar 30, 2022
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 7, 2022
@ghost
Copy link

ghost commented Apr 7, 2022

Issuance by Team:

team amount BSQ amount USD
support 508.13 625.00
dev 69.11 85.00

Total Issuance: 577.24 BSQ (equivalent to: 710.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Apr 7, 2022

Closed as accepted.

@MwithM MwithM closed this as completed Apr 7, 2022
Compensation Request Board automation moved this from Proposal Submitted to Closed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

4 participants