Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 34 #1042

Closed
chimp1984 opened this issue Mar 29, 2022 · 6 comments
Closed

For Cycle 34 #1042

chimp1984 opened this issue Mar 29, 2022 · 6 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@chimp1984
Copy link

chimp1984 commented Mar 29, 2022

Summary

  • BSQ requested: 4878.05
  • USD requested: 6000
  • BSQ rate: 1.23 USD per BSQ

Contributions delivered

Title Team USD Link Notes
Mulitple PRs dev 6000 https://github.com/bisq-network/bisq2/pulls?page=1&q=is%3Apr+author%3Achimp1984 bisq-network/bisq2#41 - bisq-network/bisq2#172

Overview of PRs:

  • Improve username domain
  • Improve channel and chatmessage domains
  • Add support delete message and edit message
  • Refactor componenets to not use shared models
  • Improve UI for Chat
  • Add sidebar with channel settings, notifications and user profile
  • Add splash screen
  • Refactor app startup
  • Add support for verifying burned BSQ for liquidity provider
  • Refactor network data model
  • Add protobuf support
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Mar 29, 2022
@ghost
Copy link

ghost commented Mar 29, 2022

Info

Read BSQ amount from summary: 4878.05
Read BSQ rate from summary: 1.23
Parsed lineitem: {"team":"dev","amount":6000}

Errors

USD amount not specified in summary section
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 4878.05 BSQ
  • Calculated total: 0.00 BSQ

@ghost ghost added the team:dev https://bisq.wiki/Dev_Team label Mar 29, 2022
@ghost
Copy link

ghost commented Mar 29, 2022

Info

Read BSQ amount from summary: 4878.05
Read BSQ rate from summary: 1.23
Parsed lineitem: {"team":"dev","amount":6000}

Errors

USD amount not specified in summary section
ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 4878.05 BSQ
  • Calculated total: 0.00 BSQ

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Mar 29, 2022
@ripcurlx
Copy link
Contributor

As dev team lead I approve this compensation request for dev. Please submit your CR to the DAO for voting and post the transaction ID here afterwards. Thanks!

@chimp1984
Copy link
Author

96dcc9847725e199c51c25d6cbe2bffe55c51e3b4fb3ff3491864a3aa882b16b

@MwithM MwithM added this to the Cycle 34 milestone Mar 29, 2022
@MwithM MwithM added this to Proposal Submitted in Compensation Request Board Mar 29, 2022
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Apr 7, 2022
@ghost
Copy link

ghost commented Apr 7, 2022

Issuance by Team:

team amount BSQ amount USD
dev 4878.05 6000.00

Total Issuance: 4878.05 BSQ (equivalent to: 6000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Apr 7, 2022

Closed as accepted.

@MwithM MwithM closed this as completed Apr 7, 2022
Compensation Request Board automation moved this from Proposal Submitted to Closed Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

3 participants