Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 18 #687

Closed
oscarguindzberg opened this issue Oct 21, 2020 · 14 comments
Closed

For Cycle 18 #687

oscarguindzberg opened this issue Oct 21, 2020 · 14 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@oscarguindzberg
Copy link

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 14705.88
  • USD requested: 10000
  • BSQ rate: 0.68 USD per BSQ
  • Previous compensation request (if applicable): For cycle 17 #662

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Segwit for bisq btc wallet dev 10000 bisq-network/bisq#4568

Context:
bisq-network/projects#42
bisq-network/proposals#247

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Oct 21, 2020
@MwithM MwithM added this to the Cycle 18 milestone Oct 22, 2020
@MwithM MwithM added this to In Review in Compensation Request Board Oct 22, 2020
@oscarguindzberg
Copy link
Author

This compensation proposal is subject to the terms of DAO proposal 247 bisq-network/proposals#247 and will be paid from the special BTC multisig escrow to @oscarguindzberg as follows, pending DAO approval in Cycle 18 voting:

USD: 10000
BSQ: 10000 / .68 = 14705.88 BSQ
BTC: 14705.88 * 0.00006239 = 0.9175, minus 0.01470588 BTC for comp req = 0.90279412 BTC net to oscar
Note: Using 30 days average 6239 sats BSQ/BTC rate from screenshot below taken at the time of compensation proposal creation

bsq-rate

@wiz
Copy link
Member

wiz commented Oct 24, 2020

@oscarguindzberg regarding the 30 days average price for BSQ/BTC, recently it seems there were some very high priced BSQ trades that moved the average BSQ/BTC rate much higher:

Screen Shot 2020-10-24 at 14 08 33

considering that these outlier trades are obviously manipulating the price much higher, maybe we should remove the very high priced trades from the calculation for the 30 day weighted average price this cycle. does that sound reasonable to you?

@wiz
Copy link
Member

wiz commented Oct 24, 2020

Alternatively I made another proposal how to calculate the "fair market price" of BSQ: bisq-network/proposals#269

@chimp1984
Copy link

0.90279412 BTC is 11,774 USD according to:
https://www.google.com/search?client=firefox-b-d&ei=4-qVX6ufFqSx5wKhuK6oCg&q=0.90279412+BTC+in+usd&oq=0.90279412+BTC+in+usd

The BSQ rate should cancel itself out from my understanding (not knowing the details of the contract).

@sqrrm
Copy link
Member

sqrrm commented Oct 25, 2020

The payout to @oscarguindzberg is denominated in USD. The exchange rate should in my opinion be the Bisq average from our price nodes at the time of payout. Another source could be used, but I think that doesn't make sense since we have one that's used as the accepted USD/BTC rate for all other usages within Bisq.

@chimp1984
Copy link

I just looked at the last comp request #662 and the same calculation was done which resulted in about 1500 USD loss due the BSQ volatility. I think we have to fix that the calculation is not adding BSQ volatility and just convert the USD to BTC and replay the loss @oscarguindzberg suffered at last cycle.

@wiz
Copy link
Member

wiz commented Oct 26, 2020

if you want to be the guarantor and deposit 4 BTC in the multisig escrow, we can make a new deal with oscar using whatever terms you want, otherwise right now i am just mediating the terms agreed between the parties that are defined in bisq-network/proposals#247

@chimp1984
Copy link

Ah ok. I have not read the initial proposal before...

So after doing a few more calculations I think the problem is that we have both the USD/BTC volatility as well as the BTC/BSQ volatility as part of the model and we apply the 30 or 90 days average on both BSQ and BTC.

The calculation with 30 days average and excluded outliers (1% threshold - see bisq-network/bisq#4706) would be:
BTC: 14705,88 * 0,00005652 = 0,8311763376 BTC
0,8311763376 BTC is 10861 USD @13068 BTC/USD
A average rate BTC/USD rate of 12031 would result in 10 000 USD. I have not run a calculation to check what was the 30/90 days average Btc price (from Bisq trades, which might be a bit different than global market rate), but it feels realistic as prices have just recently spiked to 13k.

1perc

I don't know how to deal best with the situation. The terms of the proposal/contract are matching the way it was calculated. I think the uncertainties of volatility on BTC and BSQ have been under-estimated but are a fact which we have to deal with.
The chosen model distributes the volatility risk between the guarantor and @oscarguindzberg . If we would change it to convert the requested USD directly to BTC it would be only on the shoulders of the guarantor.
Simple though example: Imagine BTC goes down to 3000 USD. The guarantor would lose then more than 3 BTC for a single months payment (and Bisq would likely not get segwit completed). On the other side if BTC goes up to 30 K @oscarguindzberg would only get 0.33 BTC and if BTC settles back down to 10k afterwards his monthly payment was much lower as expected. Of course we cannot avoid volatility but with the current model we smoothen out the risk over a period of time. It makes it harder to understand intuitively but I think its more fair and safe.

@oscarguindzberg What do you think? If you agree can you adjust your calculation with the adjusted rate where we filtered out the outliers which are suspect to price manipulation?

@oscarguindzberg
Copy link
Author

I agree to use the BSQ/BTC rate suggested by @chimp1984.

This is the updated calculation:

USD: 10000
BSQ: 10000 / .68 = 14705.88 BSQ
BTC: 14705.88 * 0.00005652 = 0,83117633, minus 0,01470588 BTC for comp req = 0,81647045 BTC net to oscar

@ripcurlx
Copy link
Member

As stand in team lead I approve this request.

@ripcurlx ripcurlx moved this from In Review to Review Complete in Compensation Request Board Oct 27, 2020
@ripcurlx
Copy link
Member

ripcurlx commented Nov 2, 2020

@oscarguindzberg Can you please post your TXID for this CR? Thanks!

@oscarguindzberg
Copy link
Author

0e589f7d3894c40c50eb32b00ed5c8789b6122ad2dded0e3042456b3216af0c1

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Nov 8, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Nov 8, 2020
@ghost
Copy link

ghost commented Nov 8, 2020

Issuance by Team:

team amount BSQ amount USD
dev 14705.88 10000.00

Total Issuance: 14705.88 BSQ (equivalent to: 10000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Nov 8, 2020

Closed as accepted.

@MwithM MwithM closed this as completed Nov 8, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

6 participants