Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 18 #705

Closed
leo816 opened this issue Oct 24, 2020 · 9 comments
Closed

For Cycle 18 #705

leo816 opened this issue Oct 24, 2020 · 9 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@leo816
Copy link

leo816 commented Oct 24, 2020

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 3011
  • USD requested: 2048
  • BSQ rate: 0.68 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 16 #651

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Mediator Support 1000 bisq-network/roles#83 (comment)
L1 Support Agent Support 500 bisq-network/roles#64 (comment)
Fee Reimbursement Agent Support 548 bisq-network/roles#76 (comment)
Support Team Lead Support bisq-network/roles#102 (comment)

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

@MwithM
Copy link
Contributor

MwithM commented Oct 25, 2020

Is this proposal still WIP or you forgot changing the title?

@ripcurlx
Copy link
Member

Is this proposal still WIP or you forgot changing the title?

@leo816 ☝️

@leo816 leo816 changed the title [WIP] For Cycle 18 For Cycle 18 Oct 26, 2020
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Oct 26, 2020
@ghost
Copy link

ghost commented Oct 26, 2020

Info

Read BSQ amount from summary: 3456
Read USD amount from summary: 2316
Read BSQ rate from summary: 0.67
Parsed lineitem: {"team":"support","amount":1000}
Parsed lineitem: {"team":"support","amount":500}
Parsed lineitem: {"team":"support","amount":548}
Parsed lineitem: {"team":"support","amount":0}

Errors

Incorrect BSQ rate specified: 0.67, expected: 0.68
ERROR: Total USD does not match the sum of line items:

  • Summary total: 2316.00 USD
  • Calculated total: 2048.00 USD

ERROR: Total BSQ does not match the sum of line items:

  • Summary total: 3456.00 BSQ
  • Calculated total: 3405.88 BSQ

@ghost ghost added team:support https://bisq.wiki/Support_Team parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Oct 26, 2020
@leo816
Copy link
Author

leo816 commented Oct 26, 2020

Is this proposal still WIP or you forgot changing the title?

Was just waiting for 2 users to provide the correct btc address in order to make the fee reimbursement payout correctly

@MwithM MwithM moved this from In Progress to In Review in Compensation Request Board Oct 26, 2020
@MwithM MwithM added this to the Cycle 18 milestone Oct 26, 2020
@leo816
Copy link
Author

leo816 commented Oct 30, 2020

Proposal tx id: 2793176f9c42b4204d7f49cb135e56b9792441fb902fd4eed29532e312eaac57

@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Oct 30, 2020
@MwithM MwithM moved this from Proposal Submitted to In Review in Compensation Request Board Oct 30, 2020
@ripcurlx
Copy link
Member

ripcurlx commented Nov 2, 2020

As stand in team lead I approve this request.

@cbeams
Copy link
Member

cbeams commented Nov 3, 2020

@leo816, I've upvoted this, but for future reference, could you explain how you calculate the amount you're requesting for Fee Reimbursement Agent each cycle? I looked through the last few compensation requests and cycle reports, and it wasn't obvious to me how you arrived at the amount requested. I'm sure there is a logic to it, and forgive me if it's already been documented or discussed somewhere, but I didn't see anything in the comments or at https://bisq.wiki/Fee_Reimbursement_Agent about it. Thanks.

@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Nov 8, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Nov 8, 2020
@ghost
Copy link

ghost commented Nov 8, 2020

Issuance by Team:

team amount BSQ amount USD
support 3011.00 2048.00

Total Issuance: 3011.00 BSQ (equivalent to: 2048.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Nov 8, 2020

Closed as accepted.

@MwithM MwithM closed this as completed Nov 8, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:support https://bisq.wiki/Support_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Development

No branches or pull requests

4 participants