Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For initial release of Bisq Trading API #8

Closed
mrosseel opened this issue Nov 6, 2017 · 3 comments
Closed

For initial release of Bisq Trading API #8

mrosseel opened this issue Nov 6, 2017 · 3 comments
Assignees

Comments

@mrosseel
Copy link
Member

mrosseel commented Nov 6, 2017

Basic information

Specify the amount of BSQ you are requesting, and the BSQ address that amount should be paid to:

  • BSQ amount requested: 11700
  • BSQ address: B1CZf25cS7KrGJnT8Z5uq8DbUApZLydCkj

Details

Provide links to the work you are requesting compensation for, along with any comments or explanations that will help stakeholders understand its value.

'Trading API', which is a HTTP API used to programmatically control a running Bisq instance.
Use cases include automation of bitcoin/alt trades, market making, gathering offer information, etc.

If you want to see it in action, see this example video.

The API reference doc is generated from the source code and is a very good starting point to get an idea of the functionality.

The main work was done in a separate repository

Sample code to access the API was provided in several languages. This repository is also the place where example trading bots can be stored.

@cbeams
Copy link
Member

cbeams commented Nov 6, 2017

Thanks for separating this out from #7, @mrosseel. Here's what I think might make the most sense:

Since this is a compensation request for a particular deliverable (the Trading API), it doesn't really matter that it's "For September 2017". So, how about we update the title of this request issue to something like "For initial release of Bisq Trading API".

Then, @ManfredKarrer can answer the question whether he considered this work as already included in the October 6th testnet genesis distribution or not.

In any case, I would recommend that we don't attempt to include this particular request in the October voting period (i.e. the voting period that is beginning today), and rather, we can include it in the next voting period that will begin on December 1st. I'm making this latter recommendation mostly for simplicity's sake, such that we can say the voting period begins right now, without needing to wait for Manfred to weigh in about this, etc.

Sound OK?

@mrosseel
Copy link
Member Author

mrosseel commented Nov 6, 2017

pretty sure this was not included in the testnet distribution, but OK to not include it in the September voting.

@mrosseel mrosseel changed the title For September 2017 For initial release of Bisq Trading API Nov 6, 2017
@ManfredKarrer
Copy link
Member

Yes the api work was not included in the genesis.

@cbeams cbeams closed this as completed Dec 18, 2017
@ghost ghost mentioned this issue Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants