Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Cycle 30 #946

Closed
chimp1984 opened this issue Nov 17, 2021 · 4 comments
Closed

For Cycle 30 #946

chimp1984 opened this issue Nov 17, 2021 · 4 comments
Assignees
@ripcurlx
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
Milestone
Cycle 30

Comments

@chimp1984
Copy link

chimp1984 commented Nov 17, 2021 •
edited

Summary

  • BSQ requested: 12062.15
  • USD requested: 21350
  • BSQ rate: 1.77 USD per BSQ

Contributions delivered

Title Team USD Link Notes
Improve fee handling dev 500 bisq-network/bisq#5826
Improve offer validation dev 100 bisq-network/bisq#5825
Fix reorg handling dev 500 bisq-network/bisq#5819
Small debugging utils dev 25 bisq-network/bisq#5818
Fix incorrect app initialisation dev 100 bisq-network/bisq#5817
Fix missing handling for non-mainnet use case dev 0 bisq-network/bisq#5816
Optimize DAO charts [7] dev 700 bisq-network/bisq#5795
Optimize trade chart view [6] dev 700 bisq-network/bisq#5794
Extract persistence of BSQ blocks out of DaoStateStore [5] dev 3000 bisq-network/bisq#5790
Redesign dao state monitoring [4] dev 2000 bisq-network/bisq#5782
Bsq swap: Implementation [3] dev 12000 bisq-network/bisq#5775
BSQ swaps: Low risk refactorings [2] dev 500 bisq-network/bisq#5770
BSQ swaps: Refactorings (non funtional changes) [1] dev 300 bisq-network/bisq#5769
Avoid that outdated donation and fee addresses are used dev 200 bisq-network/bisq#5764
Remove v2 nodes and backup nodes from DAO monitor dev 25 bisq-network/bisq#5731
Disable GC calls if fullDaoNode is set (like in case of seed nodes) dev 0 bisq-network/bisq#5728
Fix data handling if dao is deactivated dev 700 bisq-network/bisq#5711

Contributions in progress

bisq-network/bisq#5826 will get merged tomorrow, I added it as it is already ACKed and I got the plan to merge from @ripcurlx confirmed.

Note:

The work on BSQ swaps was based on the work of @sqrrm and I expect and consider it correct that he will make a request for his part of the work.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Nov 17, 2021
@ripcurlx ripcurlx added this to In Review in Compensation Request Board Nov 18, 2021
@MwithM MwithM added this to the Cycle 30 milestone Nov 18, 2021
@ripcurlx
Copy link
Contributor

My dev Team Lead review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

@MwithM MwithM moved this from In Review to Review Complete in Compensation Request Board Nov 18, 2021
@chimp1984
Copy link
Author

Tx: cf34270a5fafb5315c71d5787b414e77ae5983e87e4b96917bcc036012f8dbab

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Nov 19, 2021
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Dec 2, 2021
@ghost
Copy link

ghost commented Dec 2, 2021

Issuance by Team:

team amount BSQ amount USD
dev 12062.15 21350.00

Total Issuance: 12062.15 BSQ (equivalent to: 21350.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Dec 2, 2021

Closed as accepted

@MwithM MwithM closed this as completed Dec 2, 2021
Compensation Request Board automation moved this from Proposal Submitted to Closed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Request Board
  
Closed
Milestone
Cycle 30
Development

No branches or pull requests
3 participants
@ripcurlx @MwithM @chimp1984