Add AXE #1189
Add AXE #1189
Conversation
| @@ -88,8 +88,8 @@ public static void setBaseCurrencyCode(String baseCurrencyCode) { | |||
| final List<CryptoCurrency> result = new ArrayList<>(); | |||
|
|
|||
| if (DevEnv.DAO_TRADING_ACTIVATED) | |||
| result.add(new CryptoCurrency("BSQ", "Bisq Token")); | |||
|
|
|||
| result.add(new CryptoCurrency("AXE", "Axe")); | |||
There was a problem hiding this comment.
This doesn't look right... please revert that change.
Instead, AXE should be added a few lines down, just above this:
result.add(new CryptoCurrency("BCH", "Bitcoin Cash"));
| @Test | ||
| public void testAXE() { | ||
| AltCoinAddressValidator validator = new AltCoinAddressValidator(); | ||
| validator.setCurrencyCode("ONION"); |
There was a problem hiding this comment.
Wrong currency code.
| assertTrue(validator.validate("XYdqovfSUQvDEfmCzUCgc1FXtgxQsfCRWZ").isValid); | ||
| assertTrue(validator.validate("XZCz1HjLBQ7xAW94R4yhiQB6r6RsAuzRKx").isValid); | ||
|
|
||
| assertFalse(validator.validate("XQZAWrECjc8jBN87TbqDvoDmcvWiftsmpqq").isValid); |
There was a problem hiding this comment.
Please indent correctly.
|
Does not seem that this PR was tested. :( |
|
Thanks @jonathancross for the review. That PR came with so sloppy issues that I am not willing to spend time on testing and merging. I also don't see the address validation code. Hire a pro Java dev and avoid wasting our time please. |
|
@ManfredKarrer wow theres a lot of aggression here) having troubles building for tests on osx 10.13 and some documentation is missing as well (https://github.com/bisq-network/exchange/wiki/How-to-prepare-your-Bisq-source-code-for-regtest-mode) we would be grateful if you could keep this PR open to avoid duplicates while we working on resolution. thank you so much |
Ticker symbol: AXE
Official token name: Axe
Official block explorer URL: http://207.246.65.114:3001
Is it an Altcoin or a token: Altcoin
Official project URL: https://github.com/AXErunners/axe/wiki