Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the "Keep funds in bisq wallet" and "Move funds to External Wallet" button #327

Closed
leo816 opened this issue Apr 8, 2021 · 2 comments

Comments

@leo816
Copy link

leo816 commented Apr 8, 2021

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

On yesterday's support call we mentioned this topic:

After a trade is completed you get the option to "keep funds in your bisq wallet" but the reality is that the funds are automatically added to your wallet and the button serves no real purpose. The "Move funds to external wallet" does make sense but I see it as a confusing step that is not necessary. A user can just go into send funds and move them to his external wallet without an issue. Perhaps having just a notification saying your funds have been added to your wallet would be better in my eyes.
If there is another reason why this step exists that Im missing please let me know.

@MwithM
Copy link

MwithM commented Apr 8, 2021

This proposal is not a "significant project-wide changes or new initiatives where a broad consensus of contributors is neded", so I'm closing as invalid.
I'm not sure wether discussions or bisq/issues fits better for this requests, since this is not exactly a new feature or a bug.

Closed as invalid.

@ghubstan
Copy link
Member

ghubstan commented Apr 8, 2021

@leo816 FYI, I had to add a keepfunds method to the API to accomplish what that button does from the UI: move a completed trade's internal state to CLOSED. You have a point about the button's apparent lack of usefulness to an end user, but some interaction from the user is needed to close a trade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants