Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to 2.1 RC2 from 2 breaks backward compatibility of rules #74

Closed
maderlock opened this issue Jul 10, 2017 · 2 comments
Closed

Upgrade to 2.1 RC2 from 2 breaks backward compatibility of rules #74

maderlock opened this issue Jul 10, 2017 · 2 comments
Assignees
@der-workfloh
Milestone
2.1

Comments

@maderlock
Copy link

Before 2.1 the assumption was that all rules were regex.
In 2.1 the default is that all rules are static, and seems to apply to all the existing rules.

Therefore in upgrading my current functionality breaks. Can I suggest that even if your default becomes static, all existing rules on upgrade are set to regex to maintain backwards compatibility?
@der-workfloh
Copy link
Contributor

Hi @maderlock,

shouldn't be a problem to setup an upgrade for this. Hope to find some time this week to do so. I let you know.

@der-workfloh der-workfloh added this to the 2.1 milestone Jul 10, 2017
@der-workfloh der-workfloh self-assigned this Jul 10, 2017
der-workfloh pushed a commit that referenced this issue Jul 11, 2017
#74 Provides backwards compatibility by set strategy for existing rul…
4755037 
…es to regex matcher instead of static
der-workfloh pushed a commit that referenced this issue Jul 11, 2017
Merge pull request #77 from bitExpert/fix/74_bc_setup
e51140e 
#74 Provides backwards compatibility by set strategy for existing rul…
@der-workfloh
Copy link
Contributor

Fixed this issue with RC3 of v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@der-workfloh der-workfloh

Labels
None yet
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@maderlock @der-workfloh