UI: Fix keyboard shortcuts for other keyboard layouts #224
Conversation
I'm not sure why this commit was made, since there's no further explanation in the commit message. But using event.code breaks non-QWERTY keyboard layouts, so reverting improves my (Dvorak) experience greatly. Also, it's strongly warned against at MDN: https://developer.mozilla.org/en-US/docs/Web/API/Element/keydown_event#keyboardevent.code This also fixes ScriptEditorRoot.tsx, where some code snuck in that wasn't using *any* of the constants. This reverts commit 016a9a8.
|
Thanks to @TheMas3212, I discovered danielyxie/bitburner#3592 which was the original motivation for the change. I don't have a mac to test with, but danielyxie/bitburner#3605 claims that "Windows/Mac/Linux with US-intl/US/en_GB/NL keyboard layouts (these were all affected in the same way)" I have tested specifically with Windows US-intl. The behavior I see is that currently (on the live version of the game), if I use right-Alt+S, I get ß(eszett). This is because on intl (and presumably the others), right-Alt is mapped to AltGr. It does not show up as event.altKey (nor any other flags), so there is no way to trap for it - you will always get ß. In contrast, left-Alt is normal alt. It works properly, both currently and with my revert (and presumably, when the original bug was filed). TL;DR: I don't think the "fix" ever actually fixed anything. |
|
I'm not sure what's up with the checks. These files are not generated, as far as I'm aware, and lint was clean when I ran it myself. |
|
Yeah I have no idea what's up with these check failures either, I think this is fine for merging. |
…places" (bitburner-official#224)" The change did in fact reintroduce danielyxie/bitburner#3592 The issue was very Mac-specific, which is why my testing didn't/couldn't catch it. Plan is to bring back the use of event.key eventually (to fix the issue with different keyboard layouts), but only with a way to configure hotkeys so that users can work around their platform-specific issues. This reverts commit 70fadde.
A prior change changed from event.key to event.code. I'm not sure why this commit was made, since there's no further explanation in the commit message. But using event.code breaks non-QWERTY keyboard layouts, so reverting improves my (Dvorak) experience greatly.
Also, it's strongly warned against at MDN:
https://developer.mozilla.org/en-US/docs/Web/API/Element/keydown_event#event_properties
This also fixes ScriptEditorRoot.tsx, where some code snuck in that wasn't using any of the constants.
This reverts commit 016a9a8.
Testing
Tried the various hotkeys, they work correctly for Dvorak now. In particular, Ctrl-X (which is physically Ctrl-B) now cuts text instead of exiting to the terminal in the script editor.
Switching to Qwerty, the hotkeys match their "usual" behavior. I didn't detect any weird cases, and I tried a bunch in both layouts.