NETSCRIPT: level parameter of getActionRepGain is not really optional

[bupjae]

bitburner-src/src/NetscriptFunctions/Bladeburner.ts

Lines 141 to 155 in 303c54c

	getActionRepGain: (ctx) => (_type, _name, _level) => {
	const type = helpers.string(ctx, "type", _type);
	const name = helpers.string(ctx, "name", _name);
	const level = helpers.number(ctx, "level", _level);
	checkBladeburnerAccess(ctx);
	const action = getBladeburnerActionObject(ctx, type, name);
	let rewardMultiplier;
	if (level == null || isNaN(level)) {
	rewardMultiplier = Math.pow(action.rewardFac, action.level - 1);
	} else {
	rewardMultiplier = Math.pow(action.rewardFac, level - 1);
	}
	return action.rankGain * rewardMultiplier * BitNodeMultipliers.BladeburnerRank;
	},

On line 148, it seems the intention is make level parameter optional; if level parameter is not given, use current level of given action.

However, on line 144, if level parameter is not given properly, runtime error is thrown.

[Snarling]

Yeah that's my bad, pretty sure I messed that up. Checking the documentation verifies that level was supposed to be optional.

Moving the type verification for level after retrieving the action means we can select the correct default level, and we can also make rewardMultiplier a constant instead of needing to define it multiple ways based on a conditional.

   //...
   const action = getBladeburnerActionObject(ctx, type, name); 
   const level = _level === undefined ? action.level : helpers.number(ctx, "level", _level); 
   const rewardMultiplier = Math.pow(action.rewardFac, level - 1); 
   //...

[Snarling]

Fixed in 80d751e