forked from Bitcoin-ABC/bitcoin-abc
-
Notifications
You must be signed in to change notification settings - Fork 28
/
mempool_tests.cpp
843 lines (745 loc) · 34.8 KB
/
mempool_tests.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
// Copyright (c) 2011-2016 The Bitcoin Core developers
// Copyright (c) 2021 The Bitcoin developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#include <txmempool.h>
#include <policy/policy.h>
#include <reverse_iterator.h>
#include <util/system.h>
#include <test/setup_common.h>
#include <boost/test/unit_test.hpp>
#include <algorithm>
#include <cmath>
#include <list>
#include <vector>
BOOST_FIXTURE_TEST_SUITE(mempool_tests, TestingSetup)
BOOST_AUTO_TEST_CASE(MempoolRemoveTest) {
// Test CTxMemPool::remove functionality
TestMemPoolEntryHelper entry;
// Parent transaction with three children, and three grand-children:
CMutableTransaction txParent;
txParent.vin.resize(1);
txParent.vin[0].scriptSig = CScript() << OP_11;
txParent.vout.resize(3);
for (int i = 0; i < 3; i++) {
txParent.vout[i].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
txParent.vout[i].nValue = 33000 * SATOSHI;
}
CMutableTransaction txChild[3];
for (int i = 0; i < 3; i++) {
txChild[i].vin.resize(1);
txChild[i].vin[0].scriptSig = CScript() << OP_11;
txChild[i].vin[0].prevout = COutPoint(txParent.GetId(), i);
txChild[i].vout.resize(1);
txChild[i].vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
txChild[i].vout[0].nValue = 11000 * SATOSHI;
}
CMutableTransaction txGrandChild[3];
for (int i = 0; i < 3; i++) {
txGrandChild[i].vin.resize(1);
txGrandChild[i].vin[0].scriptSig = CScript() << OP_11;
txGrandChild[i].vin[0].prevout = COutPoint(txChild[i].GetId(), 0);
txGrandChild[i].vout.resize(1);
txGrandChild[i].vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
txGrandChild[i].vout[0].nValue = 11000 * SATOSHI;
}
CTxMemPool testPool;
LOCK2(cs_main, testPool.cs);
// Nothing in pool, remove should do nothing:
unsigned int poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txParent));
BOOST_CHECK_EQUAL(testPool.size(), poolSize);
// Just the parent:
testPool.addUnchecked(entry.FromTx(txParent));
poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txParent));
BOOST_CHECK_EQUAL(testPool.size(), poolSize - 1);
// Parent, children, grandchildren:
testPool.addUnchecked(entry.FromTx(txParent));
for (int i = 0; i < 3; i++) {
testPool.addUnchecked(entry.FromTx(txChild[i]));
testPool.addUnchecked(entry.FromTx(txGrandChild[i]));
}
// Remove Child[0], GrandChild[0] should be removed:
poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txChild[0]));
BOOST_CHECK_EQUAL(testPool.size(), poolSize - 2);
// ... make sure grandchild and child are gone:
poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txGrandChild[0]));
BOOST_CHECK_EQUAL(testPool.size(), poolSize);
poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txChild[0]));
BOOST_CHECK_EQUAL(testPool.size(), poolSize);
// Remove parent, all children/grandchildren should go:
poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txParent));
BOOST_CHECK_EQUAL(testPool.size(), poolSize - 5);
BOOST_CHECK_EQUAL(testPool.size(), 0UL);
// Add children and grandchildren, but NOT the parent (simulate the parent
// being in a block)
for (int i = 0; i < 3; i++) {
testPool.addUnchecked(entry.FromTx(txChild[i]));
testPool.addUnchecked(entry.FromTx(txGrandChild[i]));
}
// Now remove the parent, as might happen if a block-re-org occurs but the
// parent cannot be put into the mempool (maybe because it is non-standard):
poolSize = testPool.size();
testPool.removeRecursive(CTransaction(txParent));
BOOST_CHECK_EQUAL(testPool.size(), poolSize - 6);
BOOST_CHECK_EQUAL(testPool.size(), 0UL);
}
BOOST_AUTO_TEST_CASE(MempoolClearTest) {
// Test CTxMemPool::clear functionality
TestMemPoolEntryHelper entry;
// Create a transaction
CMutableTransaction txParent;
txParent.vin.resize(1);
txParent.vin[0].scriptSig = CScript() << OP_11;
txParent.vout.resize(3);
for (int i = 0; i < 3; i++) {
txParent.vout[i].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
txParent.vout[i].nValue = 33000 * SATOSHI;
}
CTxMemPool testPool;
LOCK2(cs_main, testPool.cs);
// Nothing in pool, clear should do nothing:
testPool.clear();
BOOST_CHECK_EQUAL(testPool.size(), 0UL);
// Add the transaction
testPool.addUnchecked(entry.FromTx(txParent));
BOOST_CHECK_EQUAL(testPool.size(), 1UL);
BOOST_CHECK_EQUAL(testPool.mapTx.size(), 1UL);
BOOST_CHECK_EQUAL(testPool.mapNextTx.size(), 1UL);
BOOST_CHECK_EQUAL(testPool.GetIndex().size(), 1UL);
// CTxMemPool's members should be empty after a clear
testPool.clear();
BOOST_CHECK_EQUAL(testPool.size(), 0UL);
BOOST_CHECK_EQUAL(testPool.mapTx.size(), 0UL);
BOOST_CHECK_EQUAL(testPool.mapNextTx.size(), 0UL);
BOOST_CHECK_EQUAL(testPool.GetIndex().size(), 0UL);
}
template <typename name>
static void CheckSort(CTxMemPool &pool, std::vector<std::string> &sortedOrder,
const std::string &testcase)
EXCLUSIVE_LOCKS_REQUIRED(pool.cs) {
BOOST_CHECK_EQUAL(pool.size(), sortedOrder.size());
typename CTxMemPool::indexed_transaction_set::index<name>::type::iterator
it = pool.mapTx.get<name>().begin();
int count = 0;
for (; it != pool.mapTx.get<name>().end(); ++it, ++count) {
BOOST_CHECK_MESSAGE(it->GetTx().GetId().ToString() ==
sortedOrder[count],
it->GetTx().GetId().ToString()
<< " != " << sortedOrder[count] << " in test "
<< testcase << ":" << count);
}
}
BOOST_AUTO_TEST_CASE(MempoolIndexingTest) {
CTxMemPool pool;
LOCK2(cs_main, pool.cs);
TestMemPoolEntryHelper entry;
/**
* Remove the default nonzero sigchecks, since the below tests are focussing on
* fee-based ordering and involve some artificially very tiny 21-byte
* transactions without any inputs.
*/
entry.SigChecks(0);
/* 3rd highest fee */
CMutableTransaction tx1 = CMutableTransaction();
tx1.vout.resize(1);
tx1.vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
tx1.vout[0].nValue = 10 * COIN;
/* highest fee */
CMutableTransaction tx2 = CMutableTransaction();
tx2.vout.resize(1);
tx2.vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
tx2.vout[0].nValue = 2 * COIN;
pool.addUnchecked(entry.Fee(20000 * SATOSHI).FromTx(tx2));
/* lowest fee */
CMutableTransaction tx3 = CMutableTransaction();
tx3.vout.resize(1);
tx3.vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
tx3.vout[0].nValue = 5 * COIN;
pool.addUnchecked(entry.Fee(Amount::zero()).FromTx(tx3));
/* 2nd highest fee */
CMutableTransaction tx4 = CMutableTransaction();
tx4.vout.resize(1);
tx4.vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
tx4.vout[0].nValue = 6 * COIN;
pool.addUnchecked(entry.Fee(15000 * SATOSHI).FromTx(tx4));
/* equal fee rate to tx1, but arrived later to the mempool */
CMutableTransaction tx5 = CMutableTransaction();
tx5.vout.resize(1);
tx5.vout[0].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
tx5.vout[0].nValue = 11 * COIN;
pool.addUnchecked(entry.Fee(10000 * SATOSHI).Time(100).FromTx(tx1));
pool.addUnchecked(entry.Fee(10000 * SATOSHI).Time(200).FromTx(tx5));
BOOST_CHECK_EQUAL(pool.size(), 5UL);
std::vector<std::string> sortedOrder;
sortedOrder.resize(5);
sortedOrder[0] = tx2.GetId().ToString(); // 20000
sortedOrder[1] = tx4.GetId().ToString(); // 15000
sortedOrder[3] = tx5.GetId().ToString(); // 10000
sortedOrder[2] = tx1.GetId().ToString(); // 10000
sortedOrder[4] = tx3.GetId().ToString(); // 0
CheckSort<modified_feerate>(pool, sortedOrder, "MempoolIndexingTest1");
}
BOOST_AUTO_TEST_CASE(MempoolSizeLimitTest) {
CTxMemPool pool;
LOCK2(cs_main, pool.cs);
TestMemPoolEntryHelper entry;
Amount feeIncrement = MEMPOOL_FULL_FEE_INCREMENT.GetFeePerK();
CMutableTransaction tx1 = CMutableTransaction();
tx1.vin.resize(1);
tx1.vin[0].scriptSig = CScript() << OP_1;
tx1.vout.resize(1);
tx1.vout[0].scriptPubKey = CScript() << OP_1 << OP_EQUAL;
tx1.vout[0].nValue = 10 * COIN;
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tx1));
CMutableTransaction tx2 = CMutableTransaction();
tx2.vin.resize(1);
tx2.vin[0].scriptSig = CScript() << OP_2;
tx2.vout.resize(1);
tx2.vout[0].scriptPubKey = CScript() << OP_2 << OP_EQUAL;
tx2.vout[0].nValue = 10 * COIN;
pool.addUnchecked(entry.Fee(5000 * SATOSHI).FromTx(tx2));
// should do nothing
pool.TrimToSize(pool.DynamicMemoryUsage());
BOOST_CHECK(pool.exists(tx1.GetId()));
BOOST_CHECK(pool.exists(tx2.GetId()));
// should remove the lower-feerate transaction
pool.TrimToSize(pool.DynamicMemoryUsage() * 3 / 4);
BOOST_CHECK(pool.exists(tx1.GetId()));
BOOST_CHECK(!pool.exists(tx2.GetId()));
pool.addUnchecked(entry.FromTx(tx2));
CMutableTransaction tx3 = CMutableTransaction();
tx3.vin.resize(1);
tx3.vin[0].prevout = COutPoint(tx2.GetId(), 0);
tx3.vin[0].scriptSig = CScript() << OP_2;
tx3.vout.resize(1);
tx3.vout[0].scriptPubKey = CScript() << OP_3 << OP_EQUAL;
tx3.vout[0].nValue = 10 * COIN;
pool.addUnchecked(entry.Fee(20000 * SATOSHI).FromTx(tx3));
// tx2 should be removed, tx3 is a child of tx2, so it should be removed
// even though it has highest fee.
pool.TrimToSize(pool.DynamicMemoryUsage() * 3 / 4);
BOOST_CHECK(pool.exists(tx1.GetId()));
BOOST_CHECK(!pool.exists(tx2.GetId()));
BOOST_CHECK(!pool.exists(tx3.GetId()));
// mempool is limited to tx1's size in memory usage, so nothing fits
std::vector<COutPoint> vNoSpendsRemaining;
pool.TrimToSize(CTransaction(tx1).GetTotalSize(), &vNoSpendsRemaining);
BOOST_CHECK(!pool.exists(tx1.GetId()));
BOOST_CHECK(!pool.exists(tx2.GetId()));
BOOST_CHECK(!pool.exists(tx3.GetId()));
// This vector should only contain 'root' (not unconfirmed) outpoints
// Though both tx2 and tx3 were removed, tx3's input came from tx2.
BOOST_CHECK_EQUAL(vNoSpendsRemaining.size(), 1);
BOOST_CHECK(vNoSpendsRemaining == std::vector<COutPoint>{COutPoint()});
// maxFeeRateRemoved was set by the transaction with the highest fee,
// that was not removed because it was a child of another tx.
CFeeRate maxFeeRateRemoved(10000 * SATOSHI,
CTransaction(tx1).GetTotalSize());
BOOST_CHECK_EQUAL(pool.GetMinFee(1).GetFeePerK(),
maxFeeRateRemoved.GetFeePerK() + feeIncrement);
CMutableTransaction tx4 = CMutableTransaction();
tx4.vin.resize(2);
tx4.vin[0].prevout = COutPoint();
tx4.vin[0].scriptSig = CScript() << OP_4;
tx4.vin[1].prevout = COutPoint();
tx4.vin[1].scriptSig = CScript() << OP_4;
tx4.vout.resize(2);
tx4.vout[0].scriptPubKey = CScript() << OP_4 << OP_EQUAL;
tx4.vout[0].nValue = 10 * COIN;
tx4.vout[1].scriptPubKey = CScript() << OP_4 << OP_EQUAL;
tx4.vout[1].nValue = 10 * COIN;
CMutableTransaction tx5 = CMutableTransaction();
tx5.vin.resize(2);
tx5.vin[0].prevout = COutPoint(tx4.GetId(), 0);
tx5.vin[0].scriptSig = CScript() << OP_4;
tx5.vin[1].prevout = COutPoint();
tx5.vin[1].scriptSig = CScript() << OP_5;
tx5.vout.resize(2);
tx5.vout[0].scriptPubKey = CScript() << OP_5 << OP_EQUAL;
tx5.vout[0].nValue = 10 * COIN;
tx5.vout[1].scriptPubKey = CScript() << OP_5 << OP_EQUAL;
tx5.vout[1].nValue = 10 * COIN;
CMutableTransaction tx6 = CMutableTransaction();
tx6.vin.resize(2);
tx6.vin[0].prevout = COutPoint(tx4.GetId(), 1);
tx6.vin[0].scriptSig = CScript() << OP_4;
tx6.vin[1].prevout = COutPoint();
tx6.vin[1].scriptSig = CScript() << OP_6;
tx6.vout.resize(2);
tx6.vout[0].scriptPubKey = CScript() << OP_6 << OP_EQUAL;
tx6.vout[0].nValue = 10 * COIN;
tx6.vout[1].scriptPubKey = CScript() << OP_6 << OP_EQUAL;
tx6.vout[1].nValue = 10 * COIN;
CMutableTransaction tx7 = CMutableTransaction();
tx7.vin.resize(2);
tx7.vin[0].prevout = COutPoint(tx5.GetId(), 0);
tx7.vin[0].scriptSig = CScript() << OP_5;
tx7.vin[1].prevout = COutPoint(tx6.GetId(), 0);
tx7.vin[1].scriptSig = CScript() << OP_6;
tx7.vout.resize(2);
tx7.vout[0].scriptPubKey = CScript() << OP_7 << OP_EQUAL;
tx7.vout[0].nValue = 10 * COIN;
tx7.vout[1].scriptPubKey = CScript() << OP_7 << OP_EQUAL;
tx7.vout[1].nValue = 10 * COIN;
pool.addUnchecked(entry.Fee(7000 * SATOSHI).FromTx(tx4));
pool.addUnchecked(entry.Fee(1000 * SATOSHI).FromTx(tx5));
pool.addUnchecked(entry.Fee(1100 * SATOSHI).FromTx(tx6));
pool.addUnchecked(entry.Fee(9000 * SATOSHI).FromTx(tx7));
// we only require this to remove, at max, 2 txn, because it's not clear
// what we're really optimizing for aside from that
pool.TrimToSize(pool.DynamicMemoryUsage() - 1);
BOOST_CHECK(pool.exists(tx4.GetId()));
BOOST_CHECK(pool.exists(tx6.GetId()));
BOOST_CHECK(!pool.exists(tx7.GetId()));
if (!pool.exists(tx5.GetId())) {
pool.addUnchecked(entry.Fee(1000 * SATOSHI).FromTx(tx5));
}
pool.addUnchecked(entry.Fee(9000 * SATOSHI).FromTx(tx7));
// should maximize mempool size by only removing 5/7
pool.TrimToSize(pool.DynamicMemoryUsage() / 2);
BOOST_CHECK(pool.exists(tx4.GetId()));
BOOST_CHECK(!pool.exists(tx5.GetId()));
BOOST_CHECK(pool.exists(tx6.GetId()));
BOOST_CHECK(!pool.exists(tx7.GetId()));
pool.addUnchecked(entry.Fee(1000 * SATOSHI).FromTx(tx5));
pool.addUnchecked(entry.Fee(9000 * SATOSHI).FromTx(tx7));
std::vector<CTransactionRef> vtx;
SetMockTime(42);
SetMockTime(42 + CTxMemPool::ROLLING_FEE_HALFLIFE);
BOOST_CHECK_EQUAL(pool.GetMinFee(1).GetFeePerK(),
maxFeeRateRemoved.GetFeePerK() + feeIncrement);
// ... we should keep the same min fee until we get a block
pool.removeForBlock(vtx);
SetMockTime(42 + 2 * CTxMemPool::ROLLING_FEE_HALFLIFE);
BOOST_CHECK_EQUAL(pool.GetMinFee(1).GetFeePerK(),
(maxFeeRateRemoved.GetFeePerK() + feeIncrement) / 2);
// ... then feerate should drop 1/2 each halflife
SetMockTime(42 + 2 * CTxMemPool::ROLLING_FEE_HALFLIFE +
CTxMemPool::ROLLING_FEE_HALFLIFE / 2);
// GetMinFee ceils the value, in this case, we also need to do so.
const int64_t expectedMinFee = std::ceil(
static_cast<double>(((maxFeeRateRemoved.GetFeePerK() + feeIncrement) / SATOSHI) / 4.0));
BOOST_CHECK_EQUAL(
pool.GetMinFee(pool.DynamicMemoryUsage() * 5 / 2).GetFeePerK(),
expectedMinFee * SATOSHI);
// ... with a 1/2 halflife when mempool is < 1/2 its target size
SetMockTime(42 + 2 * CTxMemPool::ROLLING_FEE_HALFLIFE +
CTxMemPool::ROLLING_FEE_HALFLIFE / 2 +
CTxMemPool::ROLLING_FEE_HALFLIFE / 4);
BOOST_CHECK_EQUAL(
pool.GetMinFee(pool.DynamicMemoryUsage() * 9 / 2).GetFeePerK(),
(maxFeeRateRemoved.GetFeePerK() + feeIncrement) / 8 + SATOSHI);
// ... with a 1/4 halflife when mempool is < 1/4 its target size
SetMockTime(0);
}
// expectedSize can be smaller than correctlyOrderedIds.size(), since we
// might be testing intermediary states. Just avoiding some slice operations,
void CheckDisconnectPoolOrder(DisconnectedBlockTransactions &disconnectPool,
std::vector<TxId> correctlyOrderedIds,
unsigned int expectedSize) {
int i = 0;
BOOST_CHECK_EQUAL(disconnectPool.GetQueuedTx().size(), expectedSize);
// Txns in queuedTx's insertion_order index are sorted from children to
// parent txn
for (const CTransactionRef &tx :
reverse_iterate(disconnectPool.GetQueuedTx().get<insertion_order>())) {
BOOST_CHECK(tx->GetId() == correctlyOrderedIds[i]);
i++;
}
}
typedef std::vector<CMutableTransaction *> vecptx;
BOOST_AUTO_TEST_CASE(TestImportMempool) {
CMutableTransaction chainedTxn[5];
std::vector<TxId> correctlyOrderedIds;
COutPoint lastOutpoint;
// Construct a chain of 5 transactions
for (int i = 0; i < 5; i++) {
chainedTxn[i].vin.emplace_back(lastOutpoint);
chainedTxn[i].vout.emplace_back(10 * SATOSHI, CScript() << OP_TRUE);
correctlyOrderedIds.push_back(chainedTxn[i].GetId());
lastOutpoint = COutPoint(correctlyOrderedIds[i], 0);
}
// The first 3 txns simulate once confirmed transactions that have been
// disconnected. We test 3 different orders: in order, one case of mixed
// order and inverted order.
vecptx disconnectedTxnsInOrder = {&chainedTxn[0], &chainedTxn[1],
&chainedTxn[2]};
vecptx disconnectedTxnsMixedOrder = {&chainedTxn[1], &chainedTxn[2],
&chainedTxn[0]};
vecptx disconnectedTxnsInvertedOrder = {&chainedTxn[2], &chainedTxn[1],
&chainedTxn[0]};
// The last 2 txns simulate a chain of unconfirmed transactions in the
// mempool. We test 2 different orders: in and out of order.
vecptx unconfTxnsInOrder = {&chainedTxn[3], &chainedTxn[4]};
vecptx unconfTxnsOutOfOrder = {&chainedTxn[4], &chainedTxn[3]};
// Now we test all combinations of the previously defined orders for
// disconnected and unconfirmed txns. The expected outcome is to have these
// transactions in the correct order in queuedTx, as defined in
// correctlyOrderedIds.
for (auto &disconnectedTxns :
{disconnectedTxnsInOrder, disconnectedTxnsMixedOrder,
disconnectedTxnsInvertedOrder}) {
for (auto &unconfTxns : {unconfTxnsInOrder, unconfTxnsOutOfOrder}) {
// addForBlock inserts disconnectTxns in disconnectPool. They
// simulate transactions that were once confirmed in a block
std::vector<CTransactionRef> vtx;
for (auto tx : disconnectedTxns) {
vtx.push_back(MakeTransactionRef(*tx));
}
DisconnectedBlockTransactions disconnectPool;
disconnectPool.addForBlock(vtx);
CheckDisconnectPoolOrder(disconnectPool, correctlyOrderedIds,
disconnectedTxns.size());
// If the mempool is empty, importMempool doesn't change
// disconnectPool
CTxMemPool testPool;
disconnectPool.importMempool(testPool);
CheckDisconnectPoolOrder(disconnectPool, correctlyOrderedIds,
disconnectedTxns.size());
{
LOCK2(cs_main, testPool.cs);
// Add all unconfirmed transactions in testPool
for (auto tx : unconfTxns) {
TestMemPoolEntryHelper entry;
testPool.addUnchecked(entry.FromTx(*tx));
}
}
// Now we test importMempool with a non empty mempool
disconnectPool.importMempool(testPool);
CheckDisconnectPoolOrder(disconnectPool, correctlyOrderedIds,
disconnectedTxns.size() +
unconfTxns.size());
// We must clear disconnectPool to not trigger the assert in its
// destructor
disconnectPool.clear();
}
}
}
inline CTransactionRef
make_tx(std::vector<Amount> &&output_values,
std::vector<CTransactionRef> &&inputs = std::vector<CTransactionRef>(),
std::vector<uint32_t> &&input_indices = std::vector<uint32_t>()) {
CMutableTransaction tx = CMutableTransaction();
tx.vin.resize(inputs.size());
tx.vout.resize(output_values.size());
for (size_t i = 0; i < inputs.size(); ++i) {
tx.vin[i].prevout =
COutPoint(inputs[i]->GetId(),
input_indices.size() > i ? input_indices[i] : 0);
}
for (size_t i = 0; i < output_values.size(); ++i) {
tx.vout[i].scriptPubKey = CScript() << OP_11 << OP_EQUAL;
tx.vout[i].nValue = output_values[i];
}
return MakeTransactionRef(tx);
}
struct TestMemPoolWithAncestryChecker : CTxMemPool
{
uint64_t CalculateDescendantMaximum(txiter entry) const EXCLUSIVE_LOCKS_REQUIRED(cs) {
// find parent with highest descendant count
std::vector<txiter> candidates;
setEntries counted;
candidates.push_back(entry);
uint64_t maximum = 0;
while (candidates.size()) {
txiter candidate = candidates.back();
candidates.pop_back();
if (!counted.insert(candidate).second) {
continue;
}
const setEntries &parents = GetMemPoolParents(candidate);
if (parents.size() == 0) {
setEntries descendants;
CalculateDescendants(candidate, descendants);
maximum = std::max(maximum, uint64_t{descendants.size()});
} else {
for (txiter i : parents) {
candidates.push_back(i);
}
}
}
return maximum;
}
void GetTransactionAncestry_deprecated_slow(const TxId &txId, size_t &ancestors, size_t &descendants) const
EXCLUSIVE_LOCKS_REQUIRED(cs) {
ancestors = descendants = 0;
auto it = mapTx.find(txId);
if (it == mapTx.end())
return;
const auto &entry = *it;
CTxMemPool::setEntries setAncestors;
std::string errString;
CalculateMemPoolAncestors(entry, setAncestors, false);
ancestors = setAncestors.size() + 1 /* add this tx */;
descendants = CalculateDescendantMaximum(it);
}
};
BOOST_AUTO_TEST_CASE(MempoolAncestryTests) {
size_t ancestors, descendants;
TestMemPoolWithAncestryChecker pool;
LOCK2(cs_main, pool.cs);
TestMemPoolEntryHelper entry;
/* Base transaction */
//
// [tx1]
//
CTransactionRef tx1 = make_tx(/* output_values */ {10 * COIN});
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tx1));
// Ancestors / descendants should be 1 / 1 (itself / itself)
pool.GetTransactionAncestry_deprecated_slow(tx1->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 1ULL);
/* Child transaction */
//
// [tx1].0 <- [tx2]
//
CTransactionRef tx2 =
make_tx(/* output_values */ {495 * CENT, 5 * COIN}, /* inputs */ {tx1});
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tx2));
// Ancestors / descendants should be:
// transaction ancestors descendants
// ============ =========== ===========
// tx1 1 (tx1) 2 (tx1,2)
// tx2 2 (tx1,2) 2 (tx1,2)
pool.GetTransactionAncestry_deprecated_slow(tx1->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 2ULL);
pool.GetTransactionAncestry_deprecated_slow(tx2->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 2ULL);
BOOST_CHECK_EQUAL(descendants, 2ULL);
/* Grand-child 1 */
//
// [tx1].0 <- [tx2].0 <- [tx3]
//
CTransactionRef tx3 = make_tx(/* output_values */ {290 * CENT, 200 * CENT},
/* inputs */ {tx2});
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tx3));
// Ancestors / descendants should be:
// transaction ancestors descendants
// ============ =========== ===========
// tx1 1 (tx1) 3 (tx1,2,3)
// tx2 2 (tx1,2) 3 (tx1,2,3)
// tx3 3 (tx1,2,3) 3 (tx1,2,3)
pool.GetTransactionAncestry_deprecated_slow(tx1->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 3ULL);
pool.GetTransactionAncestry_deprecated_slow(tx2->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 2ULL);
BOOST_CHECK_EQUAL(descendants, 3ULL);
pool.GetTransactionAncestry_deprecated_slow(tx3->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 3ULL);
/* Grand-child 2 */
//
// [tx1].0 <- [tx2].0 <- [tx3]
// |
// \---1 <- [tx4]
//
CTransactionRef tx4 = make_tx(/* output_values */ {290 * CENT, 250 * CENT},
/* inputs */ {tx2}, /* input_indices */ {1});
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tx4));
// Ancestors / descendants should be:
// transaction ancestors descendants
// ============ =========== ===========
// tx1 1 (tx1) 4 (tx1,2,3,4)
// tx2 2 (tx1,2) 4 (tx1,2,3,4)
// tx3 3 (tx1,2,3) 4 (tx1,2,3,4)
// tx4 3 (tx1,2,4) 4 (tx1,2,3,4)
pool.GetTransactionAncestry_deprecated_slow(tx1->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
pool.GetTransactionAncestry_deprecated_slow(tx2->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 2ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
pool.GetTransactionAncestry_deprecated_slow(tx3->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
pool.GetTransactionAncestry_deprecated_slow(tx4->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
/* Make an alternate branch that is longer and connect it to tx3 */
//
// [ty1].0 <- [ty2].0 <- [ty3].0 <- [ty4].0 <- [ty5].0
// |
// [tx1].0 <- [tx2].0 <- [tx3].0 <- [ty6] --->--/
// |
// \---1 <- [tx4]
//
CTransactionRef ty1, ty2, ty3, ty4, ty5;
CTransactionRef *ty[5] = {&ty1, &ty2, &ty3, &ty4, &ty5};
Amount v = 5 * COIN;
for (uint64_t i = 0; i < 5; i++) {
CTransactionRef &tyi = *ty[i];
tyi = make_tx(/* output_values */ {v},
/* inputs */ i > 0
? std::vector<CTransactionRef>{*ty[i - 1]}
: std::vector<CTransactionRef>{});
v -= 50 * CENT;
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tyi));
pool.GetTransactionAncestry_deprecated_slow(tyi->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, i + 1);
BOOST_CHECK_EQUAL(descendants, i + 1);
}
CTransactionRef ty6 =
make_tx(/* output_values */ {5 * COIN}, /* inputs */ {tx3, ty5});
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(ty6));
// Ancestors / descendants should be:
// transaction ancestors descendants
// ============ =================== ===========
// tx1 1 (tx1) 5 (tx1,2,3,4, ty6)
// tx2 2 (tx1,2) 5 (tx1,2,3,4, ty6)
// tx3 3 (tx1,2,3) 5 (tx1,2,3,4, ty6)
// tx4 3 (tx1,2,4) 5 (tx1,2,3,4, ty6)
// ty1 1 (ty1) 6 (ty1,2,3,4,5,6)
// ty2 2 (ty1,2) 6 (ty1,2,3,4,5,6)
// ty3 3 (ty1,2,3) 6 (ty1,2,3,4,5,6)
// ty4 4 (y1234) 6 (ty1,2,3,4,5,6)
// ty5 5 (y12345) 6 (ty1,2,3,4,5,6)
// ty6 9 (tx123, ty123456) 6 (ty1,2,3,4,5,6)
pool.GetTransactionAncestry_deprecated_slow(tx1->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 5ULL);
pool.GetTransactionAncestry_deprecated_slow(tx2->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 2ULL);
BOOST_CHECK_EQUAL(descendants, 5ULL);
pool.GetTransactionAncestry_deprecated_slow(tx3->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 5ULL);
pool.GetTransactionAncestry_deprecated_slow(tx4->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 5ULL);
pool.GetTransactionAncestry_deprecated_slow(ty1->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 6ULL);
pool.GetTransactionAncestry_deprecated_slow(ty2->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 2ULL);
BOOST_CHECK_EQUAL(descendants, 6ULL);
pool.GetTransactionAncestry_deprecated_slow(ty3->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 6ULL);
pool.GetTransactionAncestry_deprecated_slow(ty4->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 4ULL);
BOOST_CHECK_EQUAL(descendants, 6ULL);
pool.GetTransactionAncestry_deprecated_slow(ty5->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 5ULL);
BOOST_CHECK_EQUAL(descendants, 6ULL);
pool.GetTransactionAncestry_deprecated_slow(ty6->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 9ULL);
BOOST_CHECK_EQUAL(descendants, 6ULL);
/* Ancestors represented more than once ("diamond") */
//
// [ta].0 <- [tb].0 -----<------- [td].0
// | |
// \---1 <- [tc].0 --<--/
//
CTransactionRef ta, tb, tc, td;
ta = make_tx(/* output_values */ {10 * COIN});
tb = make_tx(/* output_values */ {5 * COIN, 3 * COIN}, /* inputs */ {ta});
tc = make_tx(/* output_values */ {2 * COIN}, /* inputs */ {tb},
/* input_indices */ {1});
td = make_tx(/* output_values */ {6 * COIN}, /* inputs */ {tb, tc},
/* input_indices */ {0, 0});
pool.clear();
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(ta));
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tb));
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(tc));
pool.addUnchecked(entry.Fee(10000 * SATOSHI).FromTx(td));
// Ancestors / descendants should be:
// transaction ancestors descendants
// ============ =================== ===========
// ta 1 (ta 4 (ta,tb,tc,td)
// tb 2 (ta,tb) 4 (ta,tb,tc,td)
// tc 3 (ta,tb,tc) 4 (ta,tb,tc,td)
// td 4 (ta,tb,tc,td) 4 (ta,tb,tc,td)
pool.GetTransactionAncestry_deprecated_slow(ta->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 1ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
pool.GetTransactionAncestry_deprecated_slow(tb->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 2ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
pool.GetTransactionAncestry_deprecated_slow(tc->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 3ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
pool.GetTransactionAncestry_deprecated_slow(td->GetId(), ancestors, descendants);
BOOST_CHECK_EQUAL(ancestors, 4ULL);
BOOST_CHECK_EQUAL(descendants, 4ULL);
}
BOOST_AUTO_TEST_CASE(GetModifiedFeeRateTest) {
CMutableTransaction tx = CMutableTransaction();
tx.vin.resize(1);
// Make tx exactly 1000 bytes.
const size_t dummyDataSize = 1000 - (GetSerializeSize(tx, PROTOCOL_VERSION)
+ 5 /* OP_PUSHDATA2 and ?? */);
tx.vin[0].scriptSig << std::vector<uint8_t>(dummyDataSize);
assert(GetSerializeSize(tx, PROTOCOL_VERSION) == 1000);
TestMemPoolEntryHelper entry;
auto entryNormal = entry.Fee(1000 * SATOSHI).FromTx(tx);
BOOST_CHECK_EQUAL(1000 * SATOSHI,
entryNormal.GetModifiedFeeRate().GetFee(1000));
// Add modified fee
CTxMemPoolEntry entryFeeModified = entry.Fee(1000 * SATOSHI).FromTx(tx);
entryFeeModified.UpdateFeeDelta(1000 * SATOSHI);
BOOST_CHECK_EQUAL(2000 * SATOSHI,
entryFeeModified.GetModifiedFeeRate().GetFee(1000));
// Excessive sigchecks count "modifies" size
CTxMemPoolEntry entrySizeModified = entry.Fee(1000 * SATOSHI)
.SigChecks(2000 / DEFAULT_BYTES_PER_SIGCHECK)
.FromTx(tx);
BOOST_CHECK_EQUAL(500 * SATOSHI,
entrySizeModified.GetModifiedFeeRate().GetFee(1000));
}
BOOST_AUTO_TEST_CASE(CompareTxMemPoolEntryByModifiedFeeRateTest) {
CTransactionRef a = make_tx(/* output_values */ {1 * COIN});
CTransactionRef b = make_tx(/* output_values */ {2 * COIN});
// For this test, we want a to have lower txid.
if (a->GetId() > b->GetId()) {
std::swap(a, b);
}
assert(a->GetId() < b->GetId());
auto MkEntry = []{ return TestMemPoolEntryHelper{}; };
CompareTxMemPoolEntryByModifiedFeeRate compare;
auto Before = [&compare](const auto &A, const auto &B){ return compare(A, B) && !compare(B, A); };
auto Equal = [&compare](const auto &A, const auto &B) { return !compare(A, B) && !compare(B, A); };
auto After = [&compare](const auto &A, const auto &B) { return compare(B, A) && !compare(A, B); };
// If the fees are the same, higher TxId and lowed TxId should compare equal
BOOST_CHECK(Equal(MkEntry().Fee(100 * SATOSHI).FromTx(a),
MkEntry().Fee(100 * SATOSHI).FromTx(b)));
// Earlier topological id, same fee, should sort before
BOOST_CHECK(Before(MkEntry().Fee(100 * SATOSHI).EntryId(1).FromTx(a),
MkEntry().Fee(100 * SATOSHI).EntryId(2).FromTx(b)));
// Smaller fee, later topoligical id sorts after
BOOST_CHECK(After(MkEntry().Fee(100 * SATOSHI).EntryId(2).FromTx(a),
MkEntry().Fee(101 * SATOSHI).EntryId(1).FromTx(b)));
// Higher fee should be the correct order, even if topological id is after
BOOST_CHECK(Before(MkEntry().Fee(101 * SATOSHI).EntryId(2).FromTx(a),
MkEntry().Fee(100 * SATOSHI).EntryId(1).FromTx(b)));
// Same with fee delta.
CTxMemPoolEntry entryA = MkEntry().Fee(100 * SATOSHI).FromTx(a);
CTxMemPoolEntry entryB = MkEntry().Fee(200 * SATOSHI).FromTx(b);
// .. A and B have same modified fee, order should be considered "equal"
entryA.UpdateFeeDelta(100 * SATOSHI);
BOOST_CHECK(Equal(entryA, entryB));
// .. B has higher modified fee.
entryB.UpdateFeeDelta(1 * SATOSHI);
BOOST_CHECK(After(entryA, entryB));
}
BOOST_AUTO_TEST_CASE(SanityCheckGetterAndSetter) {
// Basic unit test that ensures the [gs]etSanityCheck() getter/setter behave as expected
CTxMemPool pool;
const double increment = 65535.0/4294967295.0; // use this value to match resolution of CTxMemPool::nCheckFrequency
for (double d = 0.0; d <= 1.0; d += increment) {
pool.setSanityCheck(d);
// since comparing doubles is problematic, use 0.001 resolution for the equality check
BOOST_CHECK_EQUAL(int(d * 1000.0), int(pool.getSanityCheck() * 1000.0));
}
// check saturated value
pool.setSanityCheck(1.0);
BOOST_CHECK_EQUAL(int(pool.getSanityCheck() * 1000.0), 1000);
}
BOOST_AUTO_TEST_SUITE_END()