Skip to content
This repository has been archived by the owner on Nov 12, 2022. It is now read-only.

regex error with parsing name with space #1316

Closed
miketwenty1 opened this issue Nov 23, 2020 · 3 comments
Closed

regex error with parsing name with space #1316

miketwenty1 opened this issue Nov 23, 2020 · 3 comments

Comments

@miketwenty1
Copy link
Contributor

miketwenty1 commented Nov 23, 2020

7726206

Oliver Gugger commit that got pulled in will make something like this return an error due to a regex parsing issue.
./gitian-builder/bin/gverify -v -d gitian.sigs/ -r ${VERSION}-linux bitcoin/contrib/gitian-descriptors/gitian-linux.yml

./gitian-builder/bin/gverify:22:in `sanitize_path': unsanitary string in signer path (RuntimeError)

If we want spaces in the name we would need to edit gitian builder on line 22 to look something like this
[^@\w\\ '\/.:+-]
the reason for including the single quote is because git pull will make it 'Oliver Gugger'
PR/fix here if we want to allow spaces.
devrandom/gitian-builder#236

@guggero
Copy link
Contributor

guggero commented Nov 23, 2020

Oops... I didn't even notice that I created a folder with spaces in it. Sorry!
It didn't find the signing key locally when I used guggero. Any hint on how I can create an alias for it so it won't happen next time?

@miketwenty1
Copy link
Contributor Author

miketwenty1 commented Nov 23, 2020

My recommendation would be to use guggero as the folder name.. but then have a comment for gpg that has your actual name. That's what I'm doing. I would defer to @achow101 though.

Bu then again.. devrandom merged the fix. So your folder name will work now.

@miketwenty1
Copy link
Contributor Author

closing this as it's resolved.

@bitcoin-core bitcoin-core locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants