Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis should build and test arm asm #598

Closed
gmaxwell opened this issue Mar 9, 2019 · 13 comments
Closed

Travis should build and test arm asm #598

gmaxwell opened this issue Mar 9, 2019 · 13 comments

Comments

@gmaxwell
Copy link
Contributor

gmaxwell commented Mar 9, 2019

No description provided.

@gmaxwell gmaxwell added this to the initial release milestone May 23, 2019
@gmaxwell
Copy link
Contributor Author

Travis should also test make install.

@benma
Copy link
Contributor

benma commented Jul 19, 2019

Related: Travis does not seem to run ./tests. Is there a reason for that?

@real-or-random
Copy link
Contributor

It does, see https://travis-ci.org/bitcoin-core/secp256k1/jobs/560256756#L708 for example.
It just runs the entire testsuite using make check-TESTS. Maybe we should just update the README.

@benma
Copy link
Contributor

benma commented Jul 19, 2019

Of course!

Updated README here: #652

@real-or-random
Copy link
Contributor

Travis should also test different window size settings.

@real-or-random
Copy link
Contributor

Travis has now (alpha) support for ARM:
https://blog.travis-ci.com/2019-10-07-multi-cpu-architecture-support

@elichai
Copy link
Contributor

elichai commented Nov 8, 2019

FWIW it's arm64, and we have asm only for arm, not arm64.

@laanwj
Copy link
Member

laanwj commented Nov 8, 2019 •
edited

It can build and run ARM executables on ARM64 (FWIW this is what we do in bitcoin in the ARM64 travis run, see bitcoin/bitcoin#17233)

@elichai
Copy link
Contributor

elichai commented Nov 8, 2019

Didn't know arm64 can execute arm binaries. i'll give this a try

@laanwj
Copy link
Member

laanwj commented Nov 8, 2019

I think it's a feature that many SoCs have, including the one Travis happens to use, not a general requirement for arm64

@maflcko maflcko mentioned this issue Dec 5, 2019
Closed
@real-or-random real-or-random mentioned this issue Jan 6, 2020
Open
@jonasnick jonasnick removed this from the initial release milestone Apr 28, 2020
@gmaxwell
Copy link
Contributor Author

Even just having arm64 would be a big improvement. Sure, that wouldn't test that the arm ASM builds and works-- which is the critical thing motivating this issue, but there isn't anything blocking that as far as I know.

Similarly, there appears to be no BE host in this project's travis configuration. s390x is be, I believe. (lol)

@elichai
Copy link
Contributor

elichai commented Jul 28, 2020

CC #696

@real-or-random real-or-random mentioned this issue May 3, 2021
Merged
@real-or-random
Copy link
Contributor

This has been solved by #930.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@laanwj @gmaxwell @real-or-random @benma @elichai @jonasnick