add feefilter documentation #1384
Conversation
|
|
||
| | Bytes | Name | Data Type | Description | ||
| |-------|---------|-----------|--------------- | ||
| | 8 | feerate | uint64_t | *Added in protocol version 70013 as described by BIP133.* <br><br>The fee rate (in Satoshis per kilobyte) under which transactions should not be relayed to this peer. |
There was a problem hiding this comment.
Added in protocol version 70013 as described by BIP133.
is a duplicate. Already mentioned on the top.
There was a problem hiding this comment.
Thanks @Mirobit . You're right. I've removed the dupe.
|
utACK |
|
Thanks, @jnewbery ! I just sent @jnewbery some suggested edits in jnewbery#1 . I also previewed the site after those edits and it LGTM. If those edits are merged, I give a tested ACK. Here's a screenshot of that preview (edit: I just realized that the table looks broken---that's because I reduced the font size to make everything fit on one screen; it looks correct in the original):
|
|
Looks good to me. Thanks @harding! |
|
@jnewbery Heya! Just wanted to follow-up again to see if you wouldn't mind rebasing this so we could go ahead and get it on the site. |
|
Apologies for the delay on this. Rebased. |
|
What does rebased mean?
Ross
Respond back to connect.
… On Mar 8, 2017, at 3:07 PM, John Newbery ***@***.***> wrote:
Apologies for the delay on this. Rebased.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@jnewbery Thanks! @rosser2121 Here's more information on what a rebase is. Unless others object, this will be merged on Sunday, March 12th. |
| The receiving peer may choose to ignore the message and not filter transaction | ||
| inv messages. | ||
|
|
||
| The fee filter is additive with bloom filters. If an SPV client loads a bloom filter and sends a feefilter message, transactions should only be relayed if they pass both filters. |
There was a problem hiding this comment.
I think at this point it should be noted that in the case of blocks, feefilter is not additive with bloom filters.
There was a problem hiding this comment.
More specifically, I'd perhaps add "Both block and filtereredblock messages are unaffected by fee filtering."
There was a problem hiding this comment.
I think you mean "Both block and filteredblockMerkleBlock messages..." (filteredblock is an inv type rather than a message).
If we add this, I think it should be more general, ie "feefilter has no impact on block propagation or responses to getdata messages", since it also won't affect Headers or CompactBlock messages. Thoughts?
There was a problem hiding this comment.
Ah yes, that's what I meant. Your suggestion seems fine to me too.
|
@schildbach I've add a bit more explanation about feefilter interaction with block propagation and responses to getdata requests:
Let me know if you have any comments about that. @harding @wbnns let me know if you're happy with this addition and I'll squash into a single commit. |
|
Sounds fine to me. |
|
@jnewbery Looks good, thanks! |
|
Thanks for adding this! |
- Add annotated hex example - Add search box entry and autocrossref entry - Add Bitcoin Core 0.12/0.13 cross links
|
commits squashed. This is ready for merging. |
|
@jnewbery Thank you sir - will merge this as soon as tests pass. 👍 |
This PR adds documentation for the
feefiltermessage type, added in Bitcoin Core V0.13.0.