Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't do peer discovery forever #4826

Closed
Christewart opened this issue Oct 13, 2022 · 1 comment
Closed

Don't do peer discovery forever #4826

Christewart opened this issue Oct 13, 2022 · 1 comment
Labels
bug node work for the node project
Projects

Comments

@Christewart
Copy link
Contributor

in #4408 it looks like we schedule peer discoverying to go on forever. We should only do it a few times and then stop. Otherwise we constantly are making connection and getting disconnected from peers which spams our logs. I saw this when looking at #4825

private lazy val peerConnectionScheduler: Cancellable =

2022-10-13 15:46:33,946UTC INFO [P2PClientActor] Received close any state for Peer(47.221.252.141:8333)
2022-10-13 15:46:33,946UTC INFO [P2PClientActor] We've been disconnected by Peer(47.221.252.141:8333) command=Closed state=InitializedDisconnect
2022-10-13 15:46:33,957UTC INFO [P2PClientActor] Received close any state for Peer(147.194.177.165:8333)
2022-10-13 15:46:33,958UTC INFO [P2PClientActor] We've been disconnected by Peer(147.194.177.165:8333) command=Closed state=InitializedDisconnect
2022-10-13 15:46:33,979UTC INFO [P2PClientActor] Received close any state for Peer(137.184.186.236:8333)
2022-10-13 15:46:33,980UTC INFO [P2PClientActor] We've been disconnected by Peer(137.184.186.236:8333) command=Closed state=InitializedDisconnect
2022-10-13 15:46:34,205UTC INFO [P2PClientActor] Received close any state for Peer(85.165.238.7:8333)
2022-10-13 15:46:34,206UTC INFO [P2PClientActor] We've been disconnected by Peer(85.165.238.7:8333) command=Closed state=InitializedDisconnect
2022-10-13 15:46:34,316UTC INFO [P2PClientActor] Received close any state for Peer(203.214.84.182:8333)
2022-10-13 15:46:34,317UTC INFO [P2PClientActor] We've been disconnected by Peer(203.214.84.182:8333) command=Closed state=InitializedDisconnect
2022-10-13 15:46:34,401UTC INFO [P2PClientActor] Received close any state for Peer(194.191.239.98:8333)
2022-10-13 15:46:34,402UTC INFO [P2PClientActor] We've been disconnected by Peer(194.191.239.98:8333) command=Closed state=InitializedDisconnect
2022-10-13 15:46:38,989UTC INFO [P2PClientActor] Received close any state for Peer(159.223.19.31:8333)
2022-10-13 15:46:38,989UTC INFO [P2PClientActor] We've been disconnected by Peer(159.223.19.31:8333) command=Closed state=InitializedDisconnect
@Christewart Christewart added bug node work for the node project labels Oct 13, 2022
@Christewart Christewart added this to the 2.0 milestone Oct 13, 2022
@Christewart Christewart added this to TODO in 2.0 via automation Oct 13, 2022
@Christewart
Copy link
Contributor Author

Lets revisit this in the future is the changes now that we have #4847

@Christewart Christewart removed this from TODO in 2.0 Aug 22, 2023
@Christewart Christewart added this to To do in 1.9.7 via automation Aug 22, 2023
@Christewart Christewart removed this from the 2.0 milestone Aug 22, 2023
@Christewart Christewart moved this from To do to Done in 1.9.7 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug node work for the node project
Projects
No open projects
1.9.7
Done
Development

No branches or pull requests

1 participant