Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testkit reference.conf not always overriding db-commons reference.conf #5391

Open
Christewart opened this issue Feb 10, 2024 · 0 comments
Open
Labels
bug config testkit work for the testkit project
Projects
Milestone

Comments

@Christewart
Copy link
Contributor

in #5390 we see an example of this in the logs when setting log-config-on-start=true

            # reference.conf @ file:/Users/chris/dev/bitcoin-s/db-commons/target/scala-2.13/classes/reference.conf: 52
            # enable peer discovery on the p2p network by default
            "enable-peer-discovery" : true,

We want the testkit/reference.conf to always take precedent over the db-commons/reference.conf when testkit is available on this classpath, as it indicates we are running unit tests.

There is some other folks that have seemed to figure out how to fine control config resolutions here:

https://stackoverflow.com/questions/31698605/hocon-multiple-reference-conf-resolution-issue/31727841

lightbend/config#342

This should allow us to move all these hard coded configs out of these strings besides the torEnabled setting I believe

@Christewart Christewart added bug testkit work for the testkit project config labels Feb 10, 2024
@Christewart Christewart added this to the 1.9.8 milestone Feb 10, 2024
@Christewart Christewart added this to To do in 1.9.9 via automation Feb 21, 2024
@Christewart Christewart modified the milestones: 1.9.8, 1.9.9 Feb 21, 2024
@Christewart Christewart removed this from To do in 1.9.9 May 1, 2024
@Christewart Christewart added this to To do in 1.9.10 via automation May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug config testkit work for the testkit project
Projects
1.9.10
To do
Development

No branches or pull requests

1 participant