Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore of soft wallet completed ok but in report page there is a 'x' against wallet created #577

Closed
jim618 opened this issue May 25, 2015 · 5 comments
Closed

Restore of soft wallet completed ok but in report page there is a 'x' against wallet created #577

jim618 opened this issue May 25, 2015 · 5 comments
Milestone
Release 0.1

Comments

@jim618
Copy link
Contributor

jim618 commented May 25, 2015

I just did a restore of a BIP32 soft wallet from a zip backup.
It all worked fine but in the wallet restore report screen there was a X against the 'wallet created ok' message. It did not go away when the wallet synced and there were no errors in the log.
@jim618 jim618 added this to the Release 0.1 milestone May 25, 2015
@jim618
Copy link
Contributor Author

jim618 commented May 25, 2015

I think I have also seen this in the FEST tests, en passant

@jim618
Copy link
Contributor Author

jim618 commented May 25, 2015

Screenshot:

screen shot 2015-05-25 at 13 20 45

@jim618
Copy link
Contributor Author

jim618 commented May 25, 2015

Also, it is misleading to have a 'Press finish to show the wallet screen' for this usage of Wallet created successfully. Label usage needs splitting into two terms

@gary-rowe gary-rowe self-assigned this May 26, 2015
gary-rowe pushed a commit that referenced this issue May 26, 2015
#577 Change status text to not include success/failure or further ins…
465d013 
…tructions
gary-rowe pushed a commit that referenced this issue May 26, 2015
#577 Add separate note to cover "click Finish to see password" for th…
7802261 
…e wallet create process
gary-rowe added a commit that referenced this issue May 29, 2015
@gary-rowe
#577 Remove balance from logging
7b7aa51
gary-rowe added a commit that referenced this issue May 29, 2015
@gary-rowe
#577 Adjust return logic to correctly indicate wallet creation status
f3e39ec
@gary-rowe
Copy link
Contributor

Adjusted the return value in RestoreWalletReportPanelView to be true if the wallet is present, rather than depending on the Bitcoin network starting. Duplicated this logic into the Trezor restore.

This screen shot shows it working (previously it showed a cross):

screen shot 2015-05-29 at 21 51 44

Ready for review and close.

@jim618
Copy link
Contributor Author

jim618 commented May 30, 2015

Tried it out with a couple of sets of wallet words.
Worked fine.
Closing

@jim618 jim618 closed this as completed May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 0.1
Development

No branches or pull requests
2 participants
@gary-rowe @jim618