translation: Arabic

[scorpion9979]

Ongoing Arabic translation here: https://github.com/scorpion9979/bitcoin.org

Saïvann Edit : Can be reviewed live at http://bitcoinar.zapto.org/ar/

[saivann]

Great!

With just a quick look, I noticed a few problems that seem to be related to your text editor :

UTF-8 : base-ar is not UTF-8 encoded and generate weird characters. I don't know what text editor on Windows allows you to save your work with UTF-8 encoded, but it might be an option when saving. Otherwise I might recommand you to check for a free UTF-8 simple text editor. There is most likely many of them.

HTML character codes : You editor seems to use HTML character codes instead of the Arabic characters. The result in the HTML is as follow : "& #1575;& #1605;& #1604;& #1575;". That actually works.. However, it would be better to directly write the real Arabic characters instead so that anyone can open and work on these files.

C:// prefix to urls : Many files you edited have their URLs changed from /url to C://.../url, which is wrong. It looks like you are using a HTML editing software. If that's the case, you don't need such complicate editors. A very simple plain text editor will work better and won't introduce errors like this.

double tags : Same here, your editor apparently adds things that are not required. Each file you edited have a html and body tag at the start and at the end while the original files didn't have these tags. That prevents the website from building correctly, because these tags are duplicated in the layouts.

[scorpion9979]

I'm using the Google Chrome developer tools. I will try to work on these problems, also i switched the charset to UTF-8 to use real Arabic characters in the HTML code.

[saivann]

I would say Google Chrome developer tools is nice to preview the work. But the most simple text editor is what will work best for saving the result, as long as it safes everything UTF-8 encoded. I just looked at the default plain text editor on Windows and it allows you to save in UTF-8 if you specify it at saving time.

[scorpion9979]

Yes, thanks. For now i think will just focus on mere translation, i think it's better to leave all the technical stuff for the end. I will certainly try my best to make it perfect. :)

[scorpion9979]

I'm finally done with the translation, the images, layout, and the configuration, you can start reviewing my work on the pages from what i consider the main commit scorpion9979@5ba6e47 .
There are a few things that i'd like to point out:

1- I did this using the Chrome dev tools but instead of saving i used to just copy the HTML code and paste it to a text editor. I did this because i had to, when i type in Arabic inside an HTML code using a text editor annoying stuff happen (words switch sides with existing text, writing direction changes, ...) and i lose track of my work. Using the dev tools saved me from many mistakes but also introduced few that i managed to correct the most of, the only one "mistake" left as you can see from the above commit is that the "/" marks got omitted from the end of <'a href '> and <'img class'> lines. I really don't think this could cause a problem when running the pages because the browser thought it was ok to omit them.

2-Now this is important. For the Arabic writing to show up right i need to add ' dir="RTL" ' attribute inside of the <'body'> so as to make the whole page right-to-left. However, these demanded pages do not have a <'body'> tag to add the attribute to. I figured that adding this attribute to the <'body'> tag inside 'base-ar' would probably do the trick, am i correct?.

[saivann]

Great! Your current work is now visible there for review : http://bitcoinar.zapto.org/ar/

I sent you a pull request in order to fix a problem that prevents the site from building with jekyll

1- Perfect

2- Absolutely. The _layout/base-ar.html file contains the layout that is applied to all pages. Consequently, if you apply dir="RTL" there, it will apply to each of your pages.

At a first glance, I would say that it looks like all characters are too small. Please let me know what you think about this. This might require some fix in current CSS styles of the existing site, and a specific CSS file for your language to override the default font-size of the HTML page.

Can you find a second native speaker in your language to review your work and provide feedback?

I didn't review your whole work so far, but you seems to have done a good job. All links that between languages that I tested seems to be valid and working.

[scorpion9979]

I have applied the attribute and i'm going to commit it. The characters do seem rather small and faint. Maybe changing to a thicker larger font would be better. I've also noticed the "!" marks showing up instead of the spaces between the words in the <'h1'> titles.

There is another matter of page direction. For the page to be fully compatible with Arabic, you need to add the dir="RTL" attribute for the body and dir="LTR" for the rightbox so that the images of the rightbox keep orientation. This might work for other pages, but for the "choose-your-wallet" page things get really messed up and the text gets out of the boundaries. For this to work well (with the the dir="RTL" attribute for the body and dir="LTR" for the rightbox applied) the rightbox will need to be moved to the left and then align the text to the place it leaves behind. It would be perfect if this could be done in some sort of code.

I just discovered there are some typos and lack of continuity in the sentences in the html pages, i was too tired to notice them. I will review my own work tomorrow. I don't know if i can get someone else to review my work and send a feedback, there aren't many people i'm in contact with who know how to do such things.

It would be wonderful if you tell me what i need to do to prevent the U+FEFF character from appearing in my work.

[saivann]

I don't use to work with the dir="ltr|rtl" attribute but I think that we can fix all those issues with a bit of CSS that would be specific to your language and that would override the existing one. Just like what we could do for the font-size and font-family. I will take a look into this..

Sure, we always find typos and things to fix after an initial translation. That was also the case for the french version when I did it. That's why another reviewer is always a good thing. But if it is not possible, I think we can still work with one translator if you do your best to review everything in details.

Concerning the U+FEFF, I really don't know why your text editor adds this character and I had troubles finding it because it's invisible. But I only needed to erase the first "---" in each file and to type them back again to fix this.

[saivann]

OK, I have done some nice work on this. I reworked some part of the main website CSS to work better with right-to-left, I took your branch and merged it with all recent changes in the website and created a set of CSS specific rules for your language. I also applied Droid Arabic font and tested it in many browsers.

You can see the result live here :
http://bitcoinar.zapto.org/ar/

You can find the resulting work in my arabic branch :
https://github.com/saivann/bitcoin.org/tree/arabic

To overwrite your old branch with the new one, here is a way to do it :
(This will create a new folder named arabic, if this folder already exists, you need to rename it first)
(You might also want to save your current work and branch somewhere in your PC before)

1. git clone -b arabic https://github.com/saivann/bitcoin.org.git arabic
2. cd arabic
3. git checkout -b master
4. git branch -d arabic
5. git remote set-url origin https://github.com/scorpion9979/bitcoin.org.git
6. git push origin master -f

[adilmezghouti]

I speak arabic and can do the review if you have not found anybody else to do it?

[saivann]

@adilmezghouti We can't have too much reviewers ;-) But I think you are the first one. Thanks for offering yourself !

@scorpion9979 Can you enable "Issues" in the Settings of your repository so that adilmezghouti can open issues on your branch and discuss with you about what he finds? Or simply give your email, whatever you feel is best.

[scorpion9979]

@saivann Great job, i'm also still working on improving the translation and correcting the typos, i've also found a way to correct the brackets and the messed up text in this page in the developers <'u1'> code
http://bitcoinar.zapto.org/ar/%D8%AA%D8%B7%D9%88%D9%8A%D8%B1
. i did overwrite my branch with the branch you created. I'm a little hesitant of committing my work because i'm 99% sure that the U+FEFF character problem will be reintroduced.

@adilmezghouti I've just enabled issues in my repository, you can go ahead and open an issue there and we will discuss further details.

[saivann]

@scorpion9979 Your translations are more important than the U+FEFF bug. As long as we always test-build your work before accepting any updates, we will always be able to find and fix this before commiting. I will tell you if I find a way for you to fix this (like a sed line). Feel free to try things also. Thanks for your work!

[scorpion9979]

@saivann You are welcome. I've improved the translation and fixed the typos, i also fixed the "development" page and updated the text concerning anonymity. I think it is now ready for another test build 😃 .

[saivann]

@scorpion9979 : Great! I found how to remove the BOM/U+FEFF character. Just use this command line when you're done editing files :

sed -i '1 s:\xEF\xBB\xBF::' */*.html 

(Or look at your file editor if it allows you to save in UTF-8 without BOM).

http://bitcoinar.zapto.org/ar/ should be up to date. I will do a more in-depth review soon. Meanwhile two things I noticed : you can translate the word "Arabic" in your language in "_config.yml". It is used so that people can recognize their language in the list, so it's better when the name of the language in itself is translated.

Also, in the "choose-your-wallet" page, the descriptions overrides the bubbles.. The more I think about it, the more I think I want to make these bubbles "expandable" because this issue is likely to happen constantly.

[saivann]

Except for the choose-your-wallet page, the top right "Arabic" and the U+FEFF character, everything looks good to me. And of course, adilmezghouti review and feedback would be useful to see if there is a few more typos/improvements.

[scorpion9979]

@saivann I was able to remove the U+FEFF character using the sed line you provided, i've also translated the word "Arabic" in the _config.yml then removed the U+FEFF from it using
sed -i '1 s:\xEF\xBB\xBF::'_config.yml
For the "choose-your-wallet" page, i think you really should do something about these text bubbles, maybe also making their text font size smaller would help, because i don't think i can come up with a lesser translation for the descriptions.

@adilmezghouti I think it would be better if i be the one to open the issue. You can provide your feedback here:
scorpion9979#2

[saivann]

@scorpion9979 Ok, will see what I can do

[adilmezghouti]

Sounds good. I will do that.

Adil Mezghouti

On Apr 7, 2013, at 8:22, scorpion9979 notifications@github.com wrote:

@saivann I was able to remove the U+FEFF character using the sed line you provided, i've also translated the word "Arabic" in the _config.yml.
@adilmezghouti I think it would be better if i be the one to open the issue. You can provide your feedback here here:
scorpion9979#2

—
Reply to this email directly or view it on GitHub.

[scorpion9979]

@adilmezghouti Superb!

@saivann I've managed to find other typos and improved the translation for lines that i've missed before. If you would be kind and update the test site so that adilmezghouti can begin reviewing.
Also about the text bubbles problem, maybe if you would add a slide bar to the text box so you would only need to show some parts of the descriptions and then the users can scroll down for some more as in the image i've attached.
I think this might do well and would probably solve this problem for all the translations to be provided in the future, the only issue is that this might require some JavaScript and might take a while to be done.

[saivann]

that looks good indeed. However I think that I will be able to create boxes with height that adapt to the content in the next days so that we have a working setup in time.

Meanwhile, you can add this in /ar/css/main.css to cut the line-height if you want :

.previewrow>div>div{
line-height:1.3em;
}

I have updated http://bitcoinar.zapto.org/ar/

[scorpion9979]

OK. There is another matter. In the site the literal translation of "Enthusiasts" is "متحمسون" which means "the excited ones", but i translated it as "هواة" which means "hobbyists" (i thought it was more suitable and closer to the actual meaning). adilmezghouti suggested i should change it to the first one. Also there is another choice i just thought of which is "شغوفون" which means "passionates". which translation would you think is more suitable?

[saivann]

Passionates sounds good to me if it makes sense in your language

There is actually also some discussions about the name of this page in the English section. It is likely to be renamed in a near future.

[saivann]

I got to fix all issues related to scaling height in the choose-your-wallet page today. So you absolutely don't need to think about that anymore.

[saivann]

The bitcoin-for-organization page has been renamed to bitcoin-for-businesses today. You can track those changes here :
https://github.com/bitcoin/bitcoin.org/wiki/Translations-tracking

[scorpion9979]

Lovely. I've just updated my translation, would i also need to update the English and French versions from the main bitcoin repo?.

[saivann]

No, I will take care of all this stuff when merging your work along with many other technical stuff. You can only concentrate on your translation. Thanks :)

[scorpion9979]

I don't mind doing technical work. As a matter of fact, i love it!. But you're right, it's better to focus on one goal and not to deviate.

[saivann]

@scorpion9979 & @adilmezghouti : I see that there is still work in progress on your side. Just let me know when you consider the translation to be ready.

[adilmezghouti]

sounds good.

On Mon, Apr 29, 2013 at 3:03 PM, saivann notifications@github.com wrote:

@scorpion9979 https://github.com/scorpion9979 & @adilmezghoutihttps://github.com/adilmezghouti: I see that there is still work in progress on your side. Just let me know
when you consider the translation to be ready.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/105#issuecomment-17187072
.

Adil Mezghouti
Software Architect
Blog: http://www.geberlabs.com http://mibrainisopen.blogspot.com/

[scorpion9979]

ok

[saivann]

Great! Thanks for your hard work on this!

@scorpion9979 & @adilmezghouti : Please let me know if you want your username or full name to appear in the git log. This merge might be delayed a bit due to #178

[adilmezghouti]

I would love to. My full name is: Adil Mezghouti.
Thanks.

Adil Mezghouti

On May 8, 2013, at 3:11, saivann notifications@github.com wrote:

Great! Thanks for your hard work on this!

@scorpion9979 & @adilmezghouti : Please let me know if you want your username or full name to appear in the git log. This merge might be delayed a bit due to #178

—
Reply to this email directly or view it on GitHub.

[scorpion9979]

My full name is Ahmed Ihsan Tawfeek. Thanks.

[saivann]

@scorpion9979 @adilmezghouti I took the day to convert your translations to transifex and prepared the branch. If you wish to be the coordinator or a translator in the Arabic team, you are welcome. Please ask of it and you'll be added in the next hours : https://www.transifex.com/projects/p/bitcoinorg/

Transifex will make translations much easier to work with, especially for review and tracking. For instance, you'll be able to see all recent changes that needs to be translated.

[adilmezghouti]

Sure. Please go ahead and add me to the Arabic team.
Thanks.

Adil Mezghouti

On May 18, 2013, at 1:01, saivann notifications@github.com wrote:

@scorpion9979 @adilmezghouti I took the day to convert your translations to transifex and prepared the branch. If you wish to be the coordinator or a translator in the Arabic team, you are welcome. Please ask of it and you'll be added in the next hours : https://www.transifex.com/projects/p/bitcoinorg/

Transifex will make translations much easier to work with, especially for review and tracking. For instance, you'll be able to see all recent changes that needs to be translated.

—
Reply to this email directly or view it on GitHub.

[saivann]

@adilmezghouti : Actually you have to sign in to transifex and ask to be in the team so that I can accept your request. Thanks!

[adilmezghouti]

sure. thanks.

On Mon, May 20, 2013 at 12:03 PM, saivann notifications@github.com wrote:

@adilmezghouti https://github.com/adilmezghouti : Actually you have to
sign in to transifex and ask to be in the team so that I can accept your
request. Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/105#issuecomment-18155667
.

Adil Mezghouti
Software Architect
Blog: http://www.geberlabs.com http://mibrainisopen.blogspot.com/