Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GreenAddress wallet #360

Merged
merged 1 commit into from Apr 11, 2014
Merged

Conversation

greenaddress
Copy link
Contributor

This change adds GreenAddress to the wallet list.

GreenAddress has been in operation in various incarnations since 2013-04-16. GreenAddress operates similarly to BitGo in that the user holds the keys, but GreenAddress is different from Electrum, BitGo and bc.i in that wallets are BIP0032 and BIP0039 P2SH/2-of-2 multisig. Also we don’t use passphrase-encrypted private keys, but Electrum-like random mnemonic for better security. You can read about how it works in our FAQ. We've been helping the Bitcoin community with some Electrum server patches, Gentle, a tool to help deal with transactions with expired nLockTime as well as our own open source clients.

Let us know if you have any questions.

@luke-jr
Copy link
Contributor

luke-jr commented Mar 28, 2014

NACK: non-free webwallet.

Comments on the client itself:

  • Might make a good candidate if there was a way users could run their own server.
  • Name is a reference to a bad-idea proposal rejected by the community a while ago (and FAQ seems to infer it is used, although in a saner way than the original proposal).
  • Didn't see a clear answer as to whether this uses bare multisig (which is gradually becoming filtered by miners) or P2SH.

@greenaddress
Copy link
Contributor Author

NACK: non-free webwallet.

True, so far, however comparable to bc.i or bitgo.

Might make a good candidate if there was a way users could run their own server.

We are considering open sourcing the server but if that happens is probably going to be at a later stage. Note that with Gentle, users don't need the server even if we disappear.

Name is a reference to a bad-idea proposal rejected by the community a while ago (and FAQ seems to infer it is used, although in a saner way than the original proposal).

We agree the original implementation/assumption doesn't really work but we think we can rehabilitate the name with our model (which is to be based on top of the payment protocol, out of band).

Didn't see a clear answer as to whether this uses bare multisig (which is gradually becoming filtered by miners) or P2SH.

We use P2SH, we started without in 2013 but changed to P2SH towards the end of the year.

@HostFat
Copy link

HostFat commented Mar 28, 2014

Anyway, even Blockchain.info is still on the wallet list :)

@saivann
Copy link
Contributor

saivann commented Mar 29, 2014

All web wallets are generally working on desktop and mobiles, as stated in the description for this category. Wallets listed under "Desktop" and "Mobile" provide full offline control over private keys for the user, which isn't the case here to my understanding.

@Polve
Copy link

Polve commented Mar 29, 2014

I think that GreenAddress would be a nice addition to the list.

You don't have full control of private keys by design since it uses a 2of2 signature to enhance security, and I think it does a really good job at it: much better than the others in that respect since it protects you from compromised systems.

Anyway you can gain full control of your keys with pre-signed transactions with nLockTime in case their service disappear.

@greenaddress
Copy link
Contributor Author

All web wallets are generally working on desktop and mobiles, as stated in the description for this category. Wallets listed under "Desktop" and "Mobile" provide full offline control over private keys for the user, which isn't the case here to my understanding.

The user side of the multisig is fully offline and under the sole control of the user in a fully and solely local desktop app that doesn't trust the server and its data and verifies transaction before signing against two different networks (GreenAddress' and Electrum's). At no time the user keys are sent to the server, not even encrypted.

In case the server disappears the user can still spend the funds, albeit after a user selected amount of time (with our feature using nLockTime). The same applies to our Cordova mobile app.

Are all Multisig wallet automatically web wallets? Just because a webwallet version is available it doesn't necessarily mean that the desktop and mobile apps are web wallets (both of which are open source local apps with unminified inspectable code)

Assuming that even with the above clarified GreenAddress is still considered a web wallet, does this depend on its Multisig (GreenAddress side of the key) and whether the multisig it is used for security purposes, for escrow/fraud purpose, etc ? What if 'multisigness' is optional/user selectable?

We don't think lumping together mulitisig local clients and web wallet in the same category is fitting the definition, the implications are certainly quite different in our view.

We have been following related discussions and we welcome any clarification about the categories available or if found appropriate enough, new/modified, better fitting, categories.

@saivann
Copy link
Contributor

saivann commented Mar 29, 2014

@greenaddress : I think we should try avoiding duplicate listing as much as possible, it's confusing. Desktop / Mobile categories currently only list open-source software providing full control to the user, and online services are listed under the "Web" category, along with BitGo.

In general, I think changing how wallets are organized should be done consistently and separately. If anything, it probably makes more sense to only list blockchain.info under web wallets than to duplicate web wallets everywhere.

"What if 'multisigness' is optional/user selectable?"
I guess this can be revisited once this happens. But if the app is open-source and does not require the user to signup or use any online service, at a first glance, perhaps it might be considered Desktop / Mobile wallet with built-in optional services.

@greenaddress
Copy link
Contributor Author

@saivann :
We too think duplicates are wrong but we felt consistency was/is more important given the current state of things still does duplicates listing.

The current categories are confusing few orthogonal things: platform, open sourceness, where/how the keys are stored and how many keys are involved in the first place and this is not clear to end users, not even half experienced ones.

Maybe a grid with supported features and platforms could work, or perhaps duplicating listing is more consistent and correct after all.

It would be great to also show which security and privacy feature each wallet supports, to make the choice easier for inexperienced users. Above all, clarity should prevail.

Does this mean we should wait for current duplicate listings to be removed before pushing a newly consistent pull request?

I assume this pull request won't be accepted temporarily until all duplicates are removed according to a consistent rule?

Is there any room to discus and structure categories in a better fitting way?

@luke-jr
Copy link
Contributor

luke-jr commented Mar 29, 2014

The grid table is at https://en.bitcoin.it/wiki/Clients

@greenaddress
Copy link
Contributor Author

We've updated the pull request to reflect the changes suggested by @saivann - all web wallets, including Blockchain.info, are now in the 'Web wallets' category only.

@saivann
Copy link
Contributor

saivann commented Mar 29, 2014

@greenaddress Please avoid making changes to your competitors' listing. This pull req should remain focused on one thing; greenaddress. Other topics should be discussed separately.

Back to greenaddress, I didn't have time to review the service history yet.

@greenaddress
Copy link
Contributor Author

@saivann OK, re-added as above, sorry about the misunderstanding.

@mbelshe
Copy link
Contributor

mbelshe commented Apr 1, 2014

Hi, in your original message you stated that greenaddress has been in operation for over a year. The transaction you referenced is clearly dated last year, but it also isn't a P2SH address. Was that transaction created with the current greenaddress? In this reddit thread, it seems you just launched the service about 2 weeks ago: http://www.reddit.com/r/Bitcoin/comments/20g9ab/greenaddressit_trustless_2of2_open_source_wallet/

Perhaps you could clarify how long greenaddress has been running in its current form?

Disclaimer: I am with BitGo.

@greenaddress
Copy link
Contributor Author

Hi Mike,

GreenAddress' multisig wallet was lunched much earlier than 2 weeks ago, see this 8 months old post http://www.reddit.com/r/greenaddress/comments/1it70c/beta_greenaddressit_bitcoin_hybrid_wallet_and/ .

The post you reference is about open sourcing the multisig client: the first multisig service with an open source client that explicitly doesn't trust the server by checking transactions/blockchain data before signing them against the electrum network.

If you are asking if we supported P2SH from day one, the answer is no, we initially supported just classic multisig and it wasn't yet open source back then.

For the foreseeable future we plan to release new features relatively often thus changing the 'incarnation' on a regular basis to improve security, privacy and ease of use: we believe services should evolve according to the best industry standards, just like you are doing working on adding BIP0032 support to BitGo.

Hope this clarifies, please let us know if you have any doubt or concern or if you want us to further clarify.

@javgh
Copy link
Contributor

javgh commented Apr 2, 2014

FWIW, I think this would be a good addition to the wallet selection. I haven't done an in-depth review, but from what I have seen and tried out, it seems to be a very good mix of security and convenience features and probably one of the current front-runners in providing a BIP32 wallet plus two factor authentication using multi-signature addresses.

@saivann
Copy link
Contributor

saivann commented Apr 2, 2014

@javgh @mbelshe I appreciate you are taking some time to provide useful feedback and questions.

@greenaddress
Copy link
Contributor Author

@saivann we published some document that can help with GreenAddress http://ghgreenaddress.files.wordpress.com/2014/04/greenaddressp2sh2of2hd-6.pdf for review/feedback purposes

@luke-jr
Copy link
Contributor

luke-jr commented Apr 5, 2014

To clarify: my NACK applies to bc.i and BitGo as well, insofar as they are web wallets. As long as those are on the page, there's no reason to exclude GreenAddress.it specifically.

@saivann
Copy link
Contributor

saivann commented Apr 10, 2014

I have tested GreenAddress.it and recovered bitcoins from their service using nlocktime transactions sent through email notifications. In general, the service seems to be working correctly and make good use of two-factor authentication.

I have been a little wary of adding a service for which I couldn't find a lot of users reviews. This said, I didn't find anything concerning, the team behind GreenAddress is public, reviews seem generally positive and GreenAddress.it seems to be making real effort to create a web wallet with reduced centralized risk.

Therefore I agree with @luke-jr that there's probably no good reason to exclude GreenAddress.it specifically.

@saivann
Copy link
Contributor

saivann commented Apr 10, 2014

Unless someone wants to add additional comments or feedback, this will be merged on April 11th.

saivann added a commit that referenced this pull request Apr 11, 2014
@saivann saivann merged commit eaaa38a into bitcoin-dot-org:master Apr 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants