Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path issue with serialized wallets migrated from pre-0.15 to 0.15 #1812

Open
schildbach opened this issue Apr 23, 2019 · 1 comment
Open

Comments

@schildbach
Copy link
Member

When protobuf-deserializing a pre-0.15 wallet with bitcoinj 0.15, for each keychain an account path of m/0' is assumed. If the account path was customized before, it will be wrong after deserialization.

We should probably find a way to customize the default applied in https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/wallet/DeterministicKeyChain.java#L811, such that wallets that know they've been using a different account path before can use that for easier migration.

This issue was found by @oscarguindzberg

@oscarguindzberg
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants