Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink WalletEventListener.onTransactionConfidenceChanged #877

Open
mikehearn opened this issue Jun 11, 2015 · 4 comments
Open

Rethink WalletEventListener.onTransactionConfidenceChanged #877

mikehearn opened this issue Jun 11, 2015 · 4 comments
Labels
Enhancement Request for enhancement, or the implementation of one

Comments

@mikehearn
Copy link
Member

Originally reported on Google Code with ID 511

Profiling the replay process for Andreas' megawallet shows a surprising amount of time
spent simply iterating transactions in order to call them for this event listener.
The problem is confidence stores the depth and work done rather than recalculate it,
so every transaction is updated for every block. With a lot of transactions, that's
a lot of work per block.

Andreas uses this event for a bunch of things in the UI, for example, as a central
place to trigger recalculation of the list (he adds some throttling on top).

With some tweaks in both bitcoinj and the Android app we can be much smarter about
this and avoid doing lots of useless work.

Reported by hearn@google.com on 2014-01-15 16:22:53

@mikehearn
Copy link
Member Author

dogecoinj hit this problem as well.

Reported by mh.in.england on 2014-03-17 11:31:28

@mikehearn mikehearn added Enhancement Request for enhancement, or the implementation of one Priority-Medium and removed Priority-Medium labels Jun 11, 2015
@Giszmo
Copy link

Giszmo commented Apr 7, 2018

We are definitely hitting a brick wall with this one, too. Anybody working on a fix, so we don't have to stumble around, finding the same blockers?

@schildbach
Copy link
Member

I'm not aware of anyone working on this.

@schildbach
Copy link
Member

I just took a look at this and opened preview PR #1553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request for enhancement, or the implementation of one
Projects
None yet
Development

No branches or pull requests

3 participants