Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why we need a dependency on randombytes package? #133

Closed
tiero opened this issue Apr 16, 2020 · 1 comment
Closed

Why we need a dependency on randombytes package? #133

tiero opened this issue Apr 16, 2020 · 1 comment

Comments

@tiero
Copy link

tiero commented Apr 16, 2020

Although it's a well-known package, why we need to add an external dependency for just 40line of codes for browsers? (it could be made even less than that)

 crypto.getRandomValues()
@junderw
Copy link
Member

junderw commented Apr 16, 2020

for browsers

That's the reason. We are using randombytes because we want to support browsers.

If you can make the support smaller and still work securely on most browsers, please create a pull request on the randombytes repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants