Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duck-typing #1040

Closed
dcousens opened this issue Apr 13, 2018 · 3 comments
Closed

Remove duck-typing #1040

dcousens opened this issue Apr 13, 2018 · 3 comments
Labels
refactor
Milestone
4.0.0

Comments

@dcousens
Copy link
Contributor

dcousens commented Apr 13, 2018 •
edited

If possible, I'd like to try and remove the use of quacksLike.
I think any scenario where multiple versions of the underlying cryptographic primitives are being provided should be eliminated by 4.0.0, and if it did happen, it would truly be an unsafe scenario to not support duck typing anyway.

We can additionally remove the uglify-js README disclaimers. 🎆
@dabura667
Copy link
Contributor

What are the practical benefits?

What would replace it?

quacks_like?

@dcousens
Copy link
Contributor Author

instanceof?

@dcousens dcousens added this to the 4.0.0 milestone Apr 23, 2018
@dcousens
Copy link
Contributor Author

Removed in #1070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@dcousens @dabura667