Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It breaks existing ts configuration #1512

Closed
kenshyx opened this issue Nov 25, 2019 · 2 comments · Fixed by #1513
Closed

It breaks existing ts configuration #1512

kenshyx opened this issue Nov 25, 2019 · 2 comments · Fixed by #1513

Comments

@kenshyx
Copy link
Contributor

kenshyx commented Nov 25, 2019

Because @types/node is specified as a dependency, it breaks my existing project configuration:

"@types/node": "12.12.12"
"typescript": "3.7.2"

Error:

node_modules/@types/node/index.d.ts:200:11 - error TS2300: Duplicate identifier 'IteratorResult'.

The solution would be to move @types/node under devDependencies.
This was referenced Nov 25, 2019
Closed
Merged
@junderw
Copy link
Member

junderw commented Nov 26, 2019

I wonder why this hasn't come up until now... You're not the only person using this library with TypeScript...

Could you explain why you are certain that the problem exists with us and not your app? (And if it is us, why are you the first one to report it after all this time?)

@kenshyx
Copy link
Contributor Author

kenshyx commented Nov 26, 2019

This might be because most of the projects don't use incremental builds for typescript. In the tsconfig.tsbuildinfo generated by ts --build it overrides all the references for @types/node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move @types/node under devDependencies
2 participants
@kenshyx @junderw