Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECPair not in 1.5.7 in case anyone else spent hours figuring that out #408

Closed
ghost opened this issue May 21, 2015 · 8 comments
Closed

ECPair not in 1.5.7 in case anyone else spent hours figuring that out #408

ghost opened this issue May 21, 2015 · 8 comments

Comments

@ghost
Copy link

ghost commented May 21, 2015

The the most current npm module is running 1.5.7 which does not have ECPair in it. Just giving anyone else a heads up, in case they were having the same problem.

Is the master branch stable enough to push to npm, to avoid the confusion?

@jprichardson
Copy link
Member

The master branch is for version 2.0 (https://github.com/bitcoinjs/bitcoinjs-lib/blob/master/package.json#L3)

@ghost
Copy link
Author

ghost commented May 21, 2015

Guestimated release date?

@dcousens
Copy link
Contributor

@smithb1994 there a few things that still need to be done. See the 2.0.0 milestone. Once they are complete, 2.0.0 will be published.

At this time, I just haven't had time to finish it. Yet.

@dcousens dcousens added this to the 2.0.0 milestone Jun 1, 2015
@dcousens
Copy link
Contributor

dcousens commented Jun 1, 2015

@jprichardson maybe having 2.0.0 in master before being published is just a straight up bad idea. Thoughts?

@jprichardson
Copy link
Member

Yes, I think 2.0.0 should have its own branch and master should represent the stable/production release build. Perhaps we should loosely adopt gitflow conventions? At this moment could be as simple as just two branches master and 2.0.0. Thoughts?

@ghost
Copy link
Author

ghost commented Jun 1, 2015

Yes please... Not sure what the benefit is, of having dev-branch on master.

@weilu
Copy link
Contributor

weilu commented Jun 1, 2015

I don't think there's anything wrong with having master as the dev branch -- in this case, I wonder if @smithb1994 would even be aware of the existence of ECPair until 2.0 comes out. IMHO the more people we can get to test things out and give feedback, the more robust the stable versions will be.

To solve the issue @smithb1994 has, solution 1: @smithb1994 can consider put more trust on the readme in his/her node_modules folder rather than whatever is on github. 2: we link release notes on readme, and enlarge the font of the section that says "master is our development branch"

@dcousens
Copy link
Contributor

dcousens commented Jun 2, 2015

@smithb1994 it allows users who want to use the latest to easily see changes and for the general public to see that we are in active development.

It is a practice assumed by most projects, however larger projects that might have run into this issue have probably linked to documentation off GitHub, and therefore don't have this issue (directly anyway).

@ghost ghost closed this as completed Jun 28, 2015
@dcousens dcousens removed this from the 2.0.0 milestone Jul 1, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants