Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal For Segwit Update PR #53

Open
itsMikeLowrey opened this issue Mar 19, 2020 · 5 comments
Open

Proposal For Segwit Update PR #53

itsMikeLowrey opened this issue Mar 19, 2020 · 5 comments

Comments

@itsMikeLowrey
Copy link

itsMikeLowrey commented Mar 19, 2020

I would like to make a PR to update this library to default to segwit and other issues mentioned here. Most of the heavy work has been done in this PR.

I propose to build off this work and make 2 major changes to karel-3d's PR.

  1. Change Default Options to P2WSH Outputs and high R Sigs.
  2. Change coinSelect(utxos, targets, feeRate) to coinSelect(utxos, targets, feeRate, options)
    and allow developers to override the default settings with their specific cases.

Just looking for a Concept ACK before I start coding up the PR, I would hate to code the wrong thing. @junderw

@junderw
Copy link
Member

junderw commented Mar 21, 2020

ACK sounds good to me.

@monokh
Copy link

monokh commented May 20, 2020

I'm also interested in this.

I'm surprised there is not more appetite to get this through. Are people using alternatives or just settling on the pre segwit fee calculation?

@chemuto
Copy link

chemuto commented Oct 29, 2020

I'm also interested in this. Is it happening? Did you end up using another solution, @monokh ? Thanks!

@mahnunchik
Copy link

Any news?

@LeeKorbisCa
Copy link

#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants