Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modular method of injecting the needed ecc interfaces #3

Closed
motorina0 opened this issue Dec 13, 2021 · 3 comments · Fixed by #4
Closed

Add modular method of injecting the needed ecc interfaces #3

motorina0 opened this issue Dec 13, 2021 · 3 comments · Fixed by #4

Comments

@motorina0
Copy link
Member

Related to comment here: bitcoinjs/bitcoinjs-lib#1742 (comment)

Just checking if:

  • it is OK to make ecpair modular (following the bip32 lib model)?
  • someone else is not already working on this
@junderw
Copy link
Member

junderw commented Dec 13, 2021

Yes. Go ahead. I tried a couple times but couldn't really find a way that felt good.

Feel free to mess around with the interface / returning something other than the class itself. (ie. bip32 returns an object with methods to get a BIP32 instance, but not the class itself.)

@motorina0
Copy link
Member Author

PR open.
If the changes in the PR are approved then I would also like to update bitcoinjs-message (for selfish reasons).
Would that be OK?

@junderw
Copy link
Member

junderw commented Dec 14, 2021

Sure. modular ecc is fine, but we can't add schnorr to bitcoinjs-message in any way, since there's no standard for message signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants