Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ques on the code in the beep_onoff routine in the asm for atmel. #120

Closed
PEMFCS opened this issue Feb 5, 2016 · 2 comments
Closed

Ques on the code in the beep_onoff routine in the asm for atmel. #120

PEMFCS opened this issue Feb 5, 2016 · 2 comments

Comments

@PEMFCS
Copy link

PEMFCS commented Feb 5, 2016

What is the purpose of the four lines codes right after "beep_onoff"?

It seems to me of no use for the following codes, becauz only FETs of A and B were changed. will the cbr or sbr change the contents of BpFET_off, BnFET_on, AnFET_on, AnFET_off and so on?

well, i did not try to comment those lines and flash the ESC. would anyone pls to try it?

@sskaug
Copy link
Collaborator

sskaug commented Feb 19, 2016

Good point. This code was used to change between A and C fets (for stronger beeps), and did that when direction was a part of the AnFET_on etc routines. But direction was removed from the FET_on etc routines, so now the beeping no longer toggles between A and C. I forgot to update this function in the beep when direction was removed from FET_on etc.
I will take a look at fixing in the next rev.

@sskaug
Copy link
Collaborator

sskaug commented Mar 31, 2016

Will be corrected in the next rev (probably a rev14.5)

@sskaug sskaug closed this as completed Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants