Allow package to be installed with phpstan 0.12.x

[hostep]

Currently, the version constraint "phpstan/phpstan": "^0.11.6" blocks me to upgrade phpstan to 0.12.3 in one of my projects.

Would it be possible to test this package with phpstan 0.12.x and if everything is working, declare it as compatible with 0.12.x?

Suggestion would be to change the version constraint to:
"phpstan/phpstan": "^0.11.6 || ^0.12.0"

Thanks!

[hostep]

Hmm, it is probably not as easy as I would have guessed due to some backwards incompatible changes which got introduced in version 0.12.0 of phpstan, here are some errors I ran into while messing around a bit:

PHP Fatal error:  Class bitExpert\PHPStan\Magento\Reflection\MagicMethodReflection contains 7 abstract methods and must therefore be declared abstract or implement the remaining methods (PHPStan\Reflection\MethodReflection::isDeprecated, PHPStan\Reflection\MethodReflection::getDeprecatedDescription, PHPStan\Reflection\MethodReflection::isFinal, ...) in vendor/bitexpert/phpstan-magento/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php on line 20

PHP Fatal error:  Class bitExpert\PHPStan\Magento\Reflection\MagicMethodReflection contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPStan\Reflection\ClassMemberReflection::getDocComment) in vendor/bitexpert/phpstan-magento/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodReflection.php on line 22

PHP Fatal error:  Class bitExpert\PHPStan\Magento\Reflection\MagicMethodParameterReflection contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (PHPStan\Reflection\ParameterReflection::getDefaultValue) in vendor/bitexpert/phpstan-magento/src/bitExpert/PHPStan/Magento/Reflection/MagicMethodParameterReflection.php on line 20

Good to know:

• phpstan is now being delivered as a .phar file via composer since 0.12.0 (which makes it hard to find its source code in a local project)
• the source code of phpstan is moved to https://github.com/phpstan/phpstan-src/

[shochdoerfer]

@hostep thanks for opening this issue. Sure we can upgrade the package to support the latest version of PHPStan. Would you be able to contribute a MR for this?

Looks like we better start versioning this package to support multiple versions for PHPStan...

[hostep]

Hi @shochdoerfer

I could look into creating a MR, but might take me a while, bit busy with a lot of things at the moment.

It might be possible to introduce a fix in a backwards compatible fashion though, but further investigation is needed.

[hostep]

Awesome, thanks a lot @shochdoerfer!

Looks like it works perfectly after quickly testing it out over here.

Great job!