Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use round instead of float for displaying panning in mixer #57

Closed
TheNicGard opened this issue Apr 18, 2018 · 2 comments
Closed

Use round instead of float for displaying panning in mixer #57

TheNicGard opened this issue Apr 18, 2018 · 2 comments

Comments

@TheNicGard
Copy link

TheNicGard commented Apr 18, 2018 •
edited

Opening the mixer, then panning the blue or green channel left by one key press (i.e. pressing Shift + A or Shift + S to pan from "C" to "1L") doesn't display "1L" like the other channels do, but continues to display "C". Panning left again will shift the panning from "C" to "2L".

Original position of panning in each channel:
1

Pressing Shift + A once:
2

Pressing Shift + A again:
untitled
@TheNicGard TheNicGard changed the title Pressing 'red -' once in the mixer shows center panning, instead of "1L" Pressing 'blue -' once in the mixer shows center panning, instead of "1L" Apr 18, 2018
@TheNicGard TheNicGard changed the title Pressing 'blue -' once in the mixer shows center panning, instead of "1L" Pressing 'blue -' or 'green -' once in the mixer shows center panning, instead of "1L" Apr 18, 2018
@topisani
Copy link
Member

right, this is due to flooring instead of rounding, along with floating point inaccuracies. thanks for reporting

@topisani topisani changed the title Pressing 'blue -' or 'green -' once in the mixer shows center panning, instead of "1L" Use round instead of float for displaying panning in mixer Apr 18, 2018
@topisani
Copy link
Member

Mixer has been removed - see #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@topisani @TheNicGard