-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWC - Update to 2.3.x causes incorrect output #365
Comments
Thanks for the report @MolotovCherry. I’ll check this out. I wouldn’t expect things to break between minor releases unless there’s some reliance on specific debug formatting. |
I found the root cause of the bug, and it's not an issue with I'll write up the issue (or a PR) with details on the |
Thanks for the update @kosayoda. Those are my favourite kinds of bugs 😄 I’ve been on holidays this week so haven’t had a chance to dig into this yet. |
Following the linked PR it looks like you might have run into this issue. For what it’s worth, I think that is a bug in |
Ah that does make sense. I think it boils down to whether adding new flags external to the |
I think where possible we’ll try respect bits that don’t correspond to known flags. So if the bitwise operation on the underlying integer would retain that bit then the operation on the flags type will too. The only case that gets a bit weird I think is |
I've opened #366 to fix this, and think we've hashed out a plan for a If you've got any thoughts on that I'd love to hear them! |
The original bug here should be fixed as of |
This is great. I tested 2.3.3 with the original example which had the problem, and it now shows the correct output. Thanks a lot! |
Linking from this issue here -
swc-project/swc#7513
There was a problem in SWC where commas were being omitted in the output. It was determined that this was caused by
bitflags
. Something changed between2.2.1
to2.3.x
which broke SWC's output.(I'm not the maintainer of SWC, so I can't offer any input on details on SWC's usage of
bitflags
, or what/how/why anything works/doesn't work)Anyways, as of this filing date, all users who start new SWC projects (because they aren't cargo locked to an older version of bitflags) will get broken output due to this.
Edit: I have a reproducible repo here. You can verify downgrading
bitflags
fixes it withcargo update -p bitflags@2.3.1 --precise 2.2.1
The text was updated successfully, but these errors were encountered: