-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Does not update instance status on initial connect #48
Comments
Just tested, it does update if successfully to OK if it connects first. It does not update to warning or error if the ATEM is disconnected after being recognized as connected. |
@haakonnessjoen is the expected status behaviour written anywhere? I havent seen anything on the wiki, which is why this is not what you were expecting. But anyway, this should be as you expect now |
Aha, I see. We should update it then. :) I guess most modules are based on the internal tcp/udp module which have a helper function to update the status. So it’s simply forgotten. I will test tomorrow! |
Just did some testing with the build. Seems to be displaying status correctly on connect, reconnect, and disconnect. |
Im pretty sure this is fine now, if not reopen and I can take another look |
The module does not update the connection status to STATUS_WARNING while connecting, or STATUS_ERROR on disconnected, when you start companion, and the atem is unavailable. I have not tested if it updates correctly when it successfully connects first.
The text was updated successfully, but these errors were encountered: