Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending actions to disconnected ATEM crashes Companion #50

Closed
bryce-seifert opened this issue Feb 29, 2020 · 3 comments
Closed

Sending actions to disconnected ATEM crashes Companion #50

bryce-seifert opened this issue Feb 29, 2020 · 3 comments

Comments

@bryce-seifert
Copy link
Member

To recreate:
-Connect ATEM, make sure it's "OK" in Companion.
-Disconnect ATEM power or network cable.
-Press a button that has an ATEM action.
-Full Companion crash, no error

In dev mode, this in the info being returned when following the above steps:
Screen Shot 2020-02-29 at 10 09 49 AM
Screen Shot 2020-02-29 at 10 09 02 AM

I first discovered this crash at the same time as this was happening, not sure if it's related. It seems to be disconnecting repeatedly and if the button press happened to be while it was disconnected it would crash Companion.

screen_shot_2020-02-28_at_3 44 42_pm

@Julusian
Copy link
Member

Julusian commented Mar 2, 2020

This should log an error instead now.
The spamming of connections should be resolved by the connection library downgrade

@bryce-seifert
Copy link
Member Author

Seems to be stable now after initial testing, no spamming or crashes.

@Julusian
Copy link
Member

Julusian commented Mar 6, 2020

Closing as this appears resolved

@Julusian Julusian closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants