Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow to overwrite presets instead of creating new with the same name #319

Closed
lkster opened this issue Jun 22, 2020 · 4 comments

Comments

@lkster
Copy link

lkster commented Jun 22, 2020

Disclaimer:
Generally when I'm changing my own present, it changes to manual state instead of modifying existing one. Then If I click save preset after typing the same name eqMac just creates new one so then I have two presets with the same name.

Description:
It would be great If I click save preset and provide name that some preset already owns, eqMac will overwrite that preset with new settings.

User flow & interface:

  1. User changes custom preset (say it's named as mypreset) so existing one becomes manual setting
  2. User clicks save preset, dialogbox prompting to provide name shows up
  3. User provides name mypreset
  4. EqMac sees preset with name mypreset already exists so it prompts if user wants to overwrite it
  5. If user clicks ok / yes then preset is overwritten with new settings
@lkster lkster changed the title Enhancement: Allow to overwrite presents instead of creating new with the same name Enhancement: Allow to overwrite presets instead of creating new with the same name Jun 23, 2020
@nodeful
Copy link
Collaborator

nodeful commented Jun 26, 2020

I see your point. iTunes equalizer follows the flow that you have described. Will implement shortly

@shape55
Copy link

shape55 commented Dec 9, 2020

+1 on this request. There should also be a way to rename the current preset, so you don't have to save a new one and then delete the old one.

@nodeful
Copy link
Collaborator

nodeful commented Jun 25, 2021

Well only a year later... Thanks for being patient with me.
I have just released v1.0.0. You can download it here: https://github.com/bitgapp/eqMac/releases/tag/v1.0.0
Or from the website: https://eqmac.app
Could you please let me know if this issue is still present.
Thanks again.

Roman

@nodeful nodeful closed this as completed Nov 19, 2021
@shape55
Copy link

shape55 commented Feb 14, 2023

The new Save Preset window is great – thank you, but I'm noticing odd, unexpected behavior where all existing user presets are auto-saving changes. If I change a slider position of a user preset, it will save it automatically without me using the save preset option to overwrite it. This is with v1.72 on macOS Catalina 10.15.7.

Also, I don't see an option to rename presets as suggested above – not sure if this was intended to be added or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants