Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate key_io_valid.json file with valid key data #15

Closed
van-orton opened this issue Oct 13, 2020 · 3 comments · Fixed by #18
Closed

Generate key_io_valid.json file with valid key data #15

van-orton opened this issue Oct 13, 2020 · 3 comments · Fixed by #18

Comments

@van-orton
Copy link
Collaborator

Description

src/test/data/key_io_valid.json contains data for keys and this is validated during the unit test execution.
Because of the new address prefix (bgl1 instead of bc1) this file has to be regenerated for this tests section to pass.
The test section is commented out and located in src/test/key_io_tests.cpp

Solution direction

  • Check test sections in key_io_tests.cpp;
  • Build and run unit test executable and see the section failing;
  • Create a dataset that will pass the test (there are various online tools for btc, command-line BGL-cli has same arguments as bitcoin-cli to generate addresses and dump keys, etc.)
  • Fix key data that can be fixed, include new testing data if removed some to keep test robust enough;

Acceptance criteria

  • key_io_tests.cpp is running tests properly with new data in json file;
  • there are numerous test cases defined in the json file (maybe fewer than in original one, but not by order of magnitude);
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 1.0432 ETH (400.51 USD @ $383.93/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 266 years, 1 month from now.
Please review their action plans below:

1) janus has been approved to start work.

This task is challenging and interesting, I would use it to advance my understanding of BTC and BGL. I would complete this task in days.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 1.0432 ETH (384.64 USD @ $369.85/ETH) has been submitted by:


wu-emma pushed a commit that referenced this issue Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants