Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please retain breadwallet copyright notice and license #2

Closed
voisine opened this issue Sep 30, 2014 · 5 comments
Closed

please retain breadwallet copyright notice and license #2

voisine opened this issue Sep 30, 2014 · 5 comments

Comments

@voisine
Copy link
Contributor

voisine commented Sep 30, 2014

The bitheri library appears to have copied large portions from https://github.com/voisine/breadwallet

This is perfectly fine as the code is published under the MIT license, however you've removed the copyright notice. You are free to re-license the code under apache or any other license, but you must retain the original MIT license and copyright notice if you wish to comply with the licensing terms.

Thank You.

@bitwolaiye
Copy link
Contributor

Our project has learned from many open source projects (bitcoind, bitcoin-core/qt, bitcoinj, multibit, bitcoin-wallet, mycelium, and also breadwallet). Maybe there are a few classes learned from breadwallet. Currently we don't have enough time to clean up all of these (we only use scrpits to add license), and we are working hard on developpinig new functions.
Thanks for noticing, we will modify these in later version.

@voisine
Copy link
Contributor Author

voisine commented Sep 30, 2014

Then you need to retain copyright notices for all the projects that require it to not be in violation of their licensing terms. I submitted a PR for the breadwallet license.

@bitwolaiye
Copy link
Contributor

Sorry for the delay. It is holiday in China from Oct.1st to Oct.7th. Other members of our team are still on vacation now. I came back earlier, so I saw your PR and merged it.

We will retain all related copyright notices in future version.

Thanks for your notice.

@voisine
Copy link
Contributor Author

voisine commented Oct 5, 2014

I appreciate it. If you have any bug fixes or run into issues that you'd like fixed or changes you think would benefit other breadwallet codebases, I'd be happy to work together on it.

@bitwolaiye
Copy link
Contributor

Thank you. Let's all work hard together to make the Bitcoin easier and safer for normal people to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants