Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] 508/screen reader support for mat-select-search-input #137

Closed
tonyholt opened this issue Apr 3, 2019 · 7 comments · Fixed by #142
Closed

[FEATURE] 508/screen reader support for mat-select-search-input #137

tonyholt opened this issue Apr 3, 2019 · 7 comments · Fixed by #142
Labels
feature New feature or request

Comments

@tonyholt
Copy link
Contributor

tonyholt commented Apr 3, 2019

When utilizing the 508 testing tool WAVE for Chrome, there's an issue where the mat-select-search-input does not have a label. This may also be an issue when utilizing screen reading for the mat-select-search.

Could we add an @input string to optionally supply an aria-label for the mat-select-search input? We could default it to "dropdown search". This way, the screen readers and other 508 tools will not have issue with this textbox. I have a commit on a fork that illustrates where I'd like the input to be utilized:

https://github.com/tonyholt/ngx-mat-select-search/blob/6ec0468f8401d864d16660a607727115f4ecb468/src/app/mat-select-search/mat-select-search.component.html#L17

@macjohnny
Copy link
Member

sounds good. do you want to open a PR for this?

@tonyholt
Copy link
Contributor Author

tonyholt commented Apr 3, 2019

Sure. I didn't fully build out the @input, but I will try that out and issue a PR with my changes. Thank you for the quick response

@macjohnny
Copy link
Member

@macjohnny macjohnny added the feature New feature or request label Apr 8, 2019
@macjohnny
Copy link
Member

@tonyholt do you think you can implement/test this until tomorrow? if so, I would wait and include it in the next release.

@tonyholt
Copy link
Contributor Author

tonyholt commented Apr 9, 2019

@macjohnny, we can wait until the next release. I'll hopefully create the PR soon.

@macjohnny
Copy link
Member

@tonyholt any update on this?

@tonyholt
Copy link
Contributor Author

tonyholt commented Apr 29, 2019

#142

Sorry for the delay on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants