Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] select search should compare values of options #445

Closed
lorenzbaier opened this issue Oct 30, 2023 · 3 comments · Fixed by #446
Closed

[BUG] select search should compare values of options #445

lorenzbaier opened this issue Oct 30, 2023 · 3 comments · Fixed by #446

Comments

@lorenzbaier
Copy link
Contributor

ngx-mat-select-search/src/app/mat-select-search/mat-select-search.component.ts

Line 351 in d2f18e8

const firstOptionIsChanged = !this.matSelect.compareWith(previousFirstOption, currentFirstOption);

compares the actual MatOption elements instead of their values

the compareWith operates on the values of the options. see https://material.angular.io/components/select/api

image
@lorenzbaier lorenzbaier changed the title select search should compare values of options [BUG] select search should compare values of options Oct 30, 2023
@macjohnny
Copy link
Member

thanks for pointing this out! do you want to send a PR to fix this?

@lorenzbaier
Copy link
Contributor Author

Sure, i can look into it and propose a fix.

@lorenzbaier lorenzbaier mentioned this issue Nov 1, 2023
Merged
@macjohnny
Copy link
Member

@lorenzbaier thanks for the fix, it is released in 7.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix compare firstOptionIsChanged - use MatOption value lorenzbaier/ngx-mat-select-search
2 participants
@macjohnny @lorenzbaier