Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json parse fix #179

Closed
wants to merge 1 commit into from
Closed

json parse fix #179

wants to merge 1 commit into from

Conversation

vahpetr
Copy link

@vahpetr vahpetr commented Oct 8, 2016

hotfix. need research how work origin fetch method json if server return text

hotfix. need research how work origin fetch method json if server return text
@coveralls
Copy link

coveralls commented Oct 8, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 82aa3e2 on vahpetr:master into 3c053ce on bitinn:master.

@bitinn
Copy link
Collaborator

bitinn commented Oct 8, 2016

Thx for the PR. But we have many discussion on this already, the answer remains: Fetch doesn't handle cases where server returns invalid response (if you got text when you are asking for json, it's invalid response).

EDIT: That includes empty string response on status 200 when you are asking for json. empty string is invalid json.

@bitinn bitinn closed this Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants