Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bm-client vault parameters are not clear #199

Closed
acalatrava opened this issue Mar 26, 2021 · 3 comments
Closed

bm-client vault parameters are not clear #199

acalatrava opened this issue Mar 26, 2021 · 3 comments

Comments

@acalatrava
Copy link
Contributor

Describe the bug
While trying to create a new vault on a specified file the parameters will induce to an error

To Reproduce

$ ./bm-client --vault test.vault vault init

Vault already exists. Use --path to create a new vault on a specific path.

$ ./bm-client --vault test.vault vault init --path .

Please enter your new vault password:
Please retype your new vault password:
error: cannot create vault:  rename . ..backup: device or resource busy

However this works

$ ./bm-client  vault init --path test.vault

Please enter your new vault password:
Please retype your new vault password:
successfully created a new vault at  test.vault

Expected behavior
Either --path or --vault should be used as parameter but not both

@jaytaph
Copy link
Member

jaytaph commented Apr 2, 2021

@acalatrava would --vault-path be a more consistent name in these cases?

@acalatrava
Copy link
Contributor Author

Yeah, I think so. The thing is that when init one parameter is used and when edit the other one. So this should be addressed.

@jaytaph
Copy link
Member

jaytaph commented Apr 4, 2021

It seems that --path isn't an actual parameter to begin with. Only --vault is used. This is changed to --vault-path to make it less ambigius

@jaytaph jaytaph closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants