Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining initialization parameters #2

Open
danielsoro opened this issue Mar 13, 2015 · 6 comments
Open

Defining initialization parameters #2

danielsoro opened this issue Mar 13, 2015 · 6 comments
Milestone

Comments

@danielsoro
Copy link
Contributor

To properly configure tomme-cli to use a specific TomEE installation, we could pass parameters to tomee-cli in the command line in order to make it aware of a TomEE installation. The problem is that it would require typing huge command lines. A better solution would be to create a configuration file where we could put all the configuration inside and load it at initialization time. This way, the user can keep using very simple command lines to perform their repetitive work.

The configuration file could support multiple server configurations, so the user could switch from a configuration to another by simply calling (switch-to :dev) or (switch-to :test) or (switch-to :demo), where :dev, :test and :demo are three different TomEE configurations.

@danielsoro danielsoro added this to the 0.1.0 milestone Mar 14, 2015
@htmfilho
Copy link
Contributor

I think this issue can be closed after implementing the solution with the environment variable TOMEE_HOME.

@danielsoro
Copy link
Contributor Author

-1

We need fix it completely.
We can set the TOMEE_HOME env ATM, but we cannot change the environment. So, we need implement the switch-to function and define the configuration file.

I think that this configuration file needs to have some informations like:
version // tomee version.
distrubution //tomee distribuition (jaxrs / plus / plume / webprofile)
path //tomee path

We can switch the environment with file name, like: dev.properites (switch-to :dev)
blablabla.properties (switch-to :blablabla)

Maybe we can set the default path for configuration, like: ~/.tomee-cli
But, the user can change it. OFC.
WDYT!?

@danielsoro
Copy link
Contributor Author

Maybe we can define a record for this case and change it when switch-to is called.
It seem the most easy way.
It needs to be visible for all namespaces.

(defrecord tomee-cli-configuration [tomee-version tomee-distribution tomee-path])

WDYT!?

@htmfilho
Copy link
Contributor

I think this issue should be out of the milestone. There are too many questions to be answered. Maybe, we can allocate it for the next release, when we can finally get some feedback from users.

I think we should write the basics and add only what the users ask for later on. It's a way to be sure that every single functionally is effectively used.

Just my 2 cents :-)

@danielsoro danielsoro removed this from the 0.1.0 milestone Mar 14, 2015
@danielsoro
Copy link
Contributor Author

👍

@danielsoro
Copy link
Contributor Author

@htmfilho
I think that is a good alternative: https://github.com/weavejester/environ

@danielsoro danielsoro added this to the 0.1.1 milestone Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants