Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending transactions are not correctly expired #104

Open
nodestory opened this issue Dec 9, 2019 · 2 comments
Open

Pending transactions are not correctly expired #104

nodestory opened this issue Dec 9, 2019 · 2 comments
Assignees
@pieceofr
Labels
bug
Projects
Bitmark Protocol

Comments

@nodestory
Copy link
Contributor

nodestory commented Dec 9, 2019 •
edited
Loading

A pending tx is supposed to be expired after 3 days. Several hundred outdated transactions are still circulating on livenet (v0.12.4).
@nodestory nodestory added the bug label Dec 9, 2019
@nodestory nodestory added this to To do in Bitmark Protocol via automation Dec 9, 2019
@nodestory nodestory added this to the Q12020 milestone Dec 16, 2019
@nodestory
Copy link
Contributor Author

There is one node that is still running the older version of bitmarkd. After the node is shut down or upgraded, this issue could be resolved.

A proper way of expiring transactions is necessary. Including block_number (like the design in share transactions) could be an option.

@nodestory nodestory moved this from To do to In progress in Bitmark Protocol Feb 6, 2020
@nodestory nodestory modified the milestones: Q12020, Q22020 Feb 17, 2020
@nodestory nodestory moved this from In progress to To do in Bitmark Protocol Mar 13, 2020
@nodestory nodestory removed this from the Q22020 milestone Mar 13, 2020
@pieceofr pieceofr assigned pieceofr and unassigned jamieabc Mar 19, 2020
@hxw
Copy link
Member

hxw commented Jun 16, 2020

the version 0.13.2 has code to try and mitigate this

@nodestory nodestory moved this from To do to Archived in Bitmark Protocol May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pieceofr pieceofr

Labels
bug
Projects
Bitmark Protocol
  
Archived
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hxw @jamieabc @nodestory @pieceofr