Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPnP Support #79

Closed
spumer opened this issue Mar 27, 2013 · 6 comments
Closed

UPnP Support #79

spumer opened this issue Mar 27, 2013 · 6 comments
Assignees
@PeterSurda
Labels
enhancement New feature
Milestone
v0.6.0

Comments

@spumer
Copy link

spumer commented Mar 27, 2013

Please, make a UPnP support standart.
@ghost ghost assigned Atheros1 Mar 27, 2013
@travcunn
Copy link

The official Bitcoin client uses Miniupnp according to this: https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L19

It looks like there is a Python binding https://github.com/miniupnp/miniupnp/tree/master/miniupnpc

@nimdahk nimdahk mentioned this issue Aug 5, 2013
Closed
@thesues
Copy link

thesues commented Aug 7, 2013

I think miniupnp is too heavy, due to using c library.
How about using other python upnp library?

@panga
Copy link

panga commented Aug 10, 2013

There are some other python libraries for upnp:
https://github.com/skatkov/upnp-client-lib
https://code.google.com/p/miranda-upnp
https://code.google.com/p/pyupnp

@ProfessorX
Copy link

1st year graduate student of Masdar Institute. I am working on this UPnP support feature, as part of my Software Engineering course, say Project. Oh my lady gaga.

@rolandf
Copy link

rolandf commented Oct 15, 2013

@ProfessorX Nice, how is it going so far ?

@lightrabbit lightrabbit mentioned this issue Sep 17, 2015
Closed
@PeterSurda
Copy link
Member

I think @lightrabbit's patch is ok, if he makes the improvements I suggested I plan to integrate it. I'll close this when I merge it.

@PeterSurda PeterSurda added this to the v0.6.0 milestone Nov 11, 2015
@PeterSurda PeterSurda self-assigned this Nov 11, 2015
mailchuck added a commit to mailchuck/PyBitmessage that referenced this issue Nov 20, 2015
@mailchuck
UPnP support merged and fixed
b93308d 
Fixes Bitmessage#373
Fixes Bitmessage#79
Fixes #4

Needs to be turned on in the config file (keys.dat) by adding "upnp =
true" into the main section
It needs some cleanup (e.g. if you have multiple routers, it will not
correctly handle failure of one of them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterSurda PeterSurda

Labels
enhancement New feature
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
8 participants
@rolandf @panga @thesues @spumer @Atheros1 @ProfessorX @travcunn @PeterSurda