Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate the golangci-lint gosec linter in the project configuration #1459

Closed
agarcia-oss opened this issue Feb 15, 2024 · 1 comment
Closed

Activate the golangci-lint gosec linter in the project configuration #1459

agarcia-oss opened this issue Feb 15, 2024 · 1 comment
Labels
backlog Issues/PRs that will be included in the project roadmap enhancement

Comments

@agarcia-oss
Copy link
Member

Which component:
Controller and Kubeseal

Is your feature request related to a problem? Please describe.
Activate the golangci-lint gosec linter in the project configuration

Describe the solution you'd like
We'll need to activate the linter in the golangci-lint config and review/fix the issues detected.
@agarcia-oss agarcia-oss added triage Issues/PRs that need to be reviewed enhancement backlog Issues/PRs that will be included in the project roadmap and removed triage Issues/PRs that need to be reviewed labels Feb 15, 2024
@alemorcuq
Copy link
Collaborator

We've opted to use gosec as a standalone binary due to discrepancies between its report and that of golangci-lint. In #1460, I've adjusted the default severity to low and addressed the reported issue accordingly. Therefore, I'm marking this issue as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Issues/PRs that will be included in the project roadmap enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agarcia-oss @alemorcuq