This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
validate if name is set #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seh
reviewed
Oct 15, 2019
| @@ -82,6 +82,9 @@ func (c ValidateCmd) Run(apiObjects []*unstructured.Unstructured, out io.Writer) | |||
| for _, err := range schema.Validate(obj) { | |||
| allErrs = append(allErrs, err) | |||
| } | |||
| if obj.GetName() == "" { | |||
There was a problem hiding this comment.
What about ObjectMeta.GenerateName? Can kubecfg accommodate its use?
There was a problem hiding this comment.
We could generate a name ourselves using this field if it exists but server-side name generation would not work because of the way we fetch the existing resource before applying the config (it would also not support diffing).
There was a problem hiding this comment.
yeah, generateName doesn't seem compatible with the workflow promoted by kubecfg
mkmik
approved these changes
Oct 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simply checks if the name of the object is set. Without this check, the validation succeeds on typos like this:
but will panic while updating with the following error, making it especially hard to debug: