Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up the [Sidebar] Component #14

Open
poroia opened this issue Apr 19, 2020 · 0 comments
Open

Fix up the [Sidebar] Component #14

poroia opened this issue Apr 19, 2020 · 0 comments
Labels
cleanup clean up components enhancement New feature or request
Milestone

Comments

@poroia
Copy link
Collaborator

poroia commented Apr 19, 2020

Several instances of a [Sidebar] component exist throughout the project: one in Learn, one in Explore, and one in Teacher. We need to combine them and create several variants. It would be best to start from the one in the Teacher View, as the look-and-feel of it is what we want to pursue.

image

This picture is under Explore Page Module Page World Page and Activity View under the Student View in Figma.

If you would like to work on this, please contact Bryan Wong on Slack to give yourself a role of the teacher by getting your account a teacherId.

Notes: This would be more difficult as it involves knowing more features of the project and modifying multiple parts of the project while still keeping it intact.

For now, place this component under src/components/shared/high

This component can be directly created in the Module component (which already has content at the moment, but will need to be eventually reimplemented like in the Figma under Module Page, so ignore the other content for now and create this component below it). This component can be accessed through src/components/Module/Module.js. As shown in App.js, this component/view can be accessed by typing in the url: /modules/:id where :id is equal to any number

@poroia poroia added cleanup clean up components enhancement New feature or request labels Apr 20, 2020
@Abishek1997 Abishek1997 pinned this issue Apr 25, 2020
@bryanwong8 bryanwong8 added this to the Module.js milestone May 2, 2020
@Abishek1997 Abishek1997 unpinned this issue May 10, 2020
@Abishek1997 Abishek1997 removed their assignment May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup clean up components enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants